You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/08 09:46:00 UTC
[jira] [Commented] (AIRFLOW-6508) Update the version of cattrs from
0.9 to 1.0
[ https://issues.apache.org/jira/browse/AIRFLOW-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010524#comment-17010524 ]
ASF GitHub Bot commented on AIRFLOW-6508:
-----------------------------------------
sarutak commented on pull request #7100: [AIRFLOW-6508] Update the version of cattrs from 0.9 to 1.0
URL: https://github.com/apache/airflow/pull/7100
cattrs 0.9 with Python 3.8 causes following error.
```
$ airflow
Traceback (most recent call last):
File "/Users/sarutak/airflow-env/bin/airflow", line 27, in <module>
from airflow.bin.cli import CLIFactory
File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/__init__.py", line 40, in <module>
from airflow.models.dag import DAG
File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/models/__init__.py", line 21, in <module>
from airflow.models.baseoperator import BaseOperator, BaseOperatorLink # noqa: F401
File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/models/baseoperator.py", line 41, in <module>
from airflow.lineage import apply_lineage, prepare_lineage
File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/lineage/__init__.py", line 28, in <module>
from cattr import structure, unstructure
File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/__init__.py", line 2, in <module>
from .converters import Converter, UnstructureStrategy
File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/converters.py", line 3, in <module>
from ._compat import (
File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/_compat.py", line 86, in <module>
from typing import _Union
ImportError: cannot import name '_Union' from 'typing' (/opt/python/3.8.0/lib/python3.8/typing.py)
```
This issue is resolved in cattrs 1.0.
https://github.com/Tinche/cattrs/pull/73
So let's update it.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Update the version of cattrs from 0.9 to 1.0
> --------------------------------------------
>
> Key: AIRFLOW-6508
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6508
> Project: Apache Airflow
> Issue Type: Improvement
> Components: build
> Affects Versions: 1.10.8
> Reporter: Kousuke Saruta
> Assignee: Kousuke Saruta
> Priority: Major
>
> cattrs 0.9 with Python 3.8 causes following error.
> {code:java}
> $ airflow
> Traceback (most recent call last):
> File "/Users/sarutak/airflow-env/bin/airflow", line 27, in <module>
> from airflow.bin.cli import CLIFactory
> File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/__init__.py", line 40, in <module>
> from airflow.models.dag import DAG
> File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/models/__init__.py", line 21, in <module>
> from airflow.models.baseoperator import BaseOperator, BaseOperatorLink # noqa: F401
> File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/models/baseoperator.py", line 41, in <module>
> from airflow.lineage import apply_lineage, prepare_lineage
> File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/airflow/lineage/__init__.py", line 28, in <module>
> from cattr import structure, unstructure
> File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/__init__.py", line 2, in <module>
> from .converters import Converter, UnstructureStrategy
> File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/converters.py", line 3, in <module>
> from ._compat import (
> File "/Users/sarutak/airflow-env/lib/python3.8/site-packages/cattr/_compat.py", line 86, in <module>
> from typing import _Union
> ImportError: cannot import name '_Union' from 'typing' (/opt/python/3.8.0/lib/python3.8/typing.py) {code}
> This issue is resolved in cattrs 1.0.
> [https://github.com/Tinche/cattrs/pull/73]
> So let's update it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)