You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2023/02/02 18:59:01 UTC
[GitHub] [accumulo-proxy] DomGarguilo opened a new pull request, #72: WIP - fix CompactionSelecor test
DomGarguilo opened a new pull request, #72:
URL: https://github.com/apache/accumulo-proxy/pull/72
Fixes #71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] DomGarguilo merged pull request #72: Fix CompactionSelecor test
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #72:
URL: https://github.com/apache/accumulo-proxy/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] DomGarguilo commented on pull request #72: WIP - fix CompactionSelecor test
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #72:
URL: https://github.com/apache/accumulo-proxy/pull/72#issuecomment-1414220528
Currently, the changes in this PR make it so that the condition that was trying to be assessed, that the compation selector is working, is actually being assessed. This is causing the test to fail because something is wrong and the file count is not changing as expected.
The message that prints out when the tests fails is: `Expected to find 13 files but found 26`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] DomGarguilo commented on pull request #72: Fix CompactionSelecor test
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #72:
URL: https://github.com/apache/accumulo-proxy/pull/72#issuecomment-1420932269
Marking this as ready for review. I changed the `Selector` used in the test to the `TooManyDeletesSelector`. I modified the test to use this selector and based it off of `CompactionExecutorIT.testTooManyDeletes`. The point of the test is to make sure a selector can be specified from the proxy client and will take affect during compactions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org