You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2017/01/01 12:18:25 UTC

svn commit: r1776846 - /subversion/trunk/build.conf

Author: stefan2
Date: Sun Jan  1 12:18:25 2017
New Revision: 1776846

URL: http://svn.apache.org/viewvc?rev=1776846&view=rev
Log:
Fix yet another symbol export issue under Windows.

* build.conf
  (libsvn_repos): Make sure to export private symbols needed by our tests.

Modified:
    subversion/trunk/build.conf

Modified: subversion/trunk/build.conf
URL: http://svn.apache.org/viewvc/subversion/trunk/build.conf?rev=1776846&r1=1776845&r2=1776846&view=diff
==============================================================================
--- subversion/trunk/build.conf (original)
+++ subversion/trunk/build.conf Sun Jan  1 12:18:25 2017
@@ -362,7 +362,7 @@ type = lib
 path = subversion/libsvn_repos
 install = ramod-lib
 libs = libsvn_fs libsvn_delta libsvn_subr apriconv apr
-msvc-export = svn_repos.h  private/svn_repos_private.h
+msvc-export = svn_repos.h  private/svn_repos_private.h ../libsvn_repos/authz.h
 
 # Low-level grab bag of utilities
 [libsvn_subr]



RE: svn commit: r1776846 - /subversion/trunk/build.conf

Posted by Bert Huijben <be...@qqmail.nl>.

> -----Original Message-----
> From: stefan2@apache.org [mailto:stefan2@apache.org]
> Sent: zondag 1 januari 2017 13:18
> To: commits@subversion.apache.org
> Subject: svn commit: r1776846 - /subversion/trunk/build.conf
> 
> Author: stefan2
> Date: Sun Jan  1 12:18:25 2017
> New Revision: 1776846
> 
> URL: http://svn.apache.org/viewvc?rev=1776846&view=rev
> Log:
> Fix yet another symbol export issue under Windows.
> 
> * build.conf
>   (libsvn_repos): Make sure to export private symbols needed by our tests.

As you don't note which test this applies to: there are other ways to fix tests than making functions exported.

Some of our tests explicitly link statically to our libraries to have complete access to usually private functions. I think this is now configured in build.conf, but there used to be some magic name requirement to trigger this behavior.

	Bert