You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/23 14:08:42 UTC
[GitHub] [superset] kgabryje opened a new pull request, #20160: Feat/annotations empty state
kgabryje opened a new pull request, #20160:
URL: https://github.com/apache/superset/pull/20160
### SUMMARY
When there's no annotation sources available, display an empty state with a link to annotation layers view
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="240" alt="image" src="https://user-images.githubusercontent.com/15073128/169838149-b983cfd7-3c35-4acb-8dec-393d7938a408.png">
### TESTING INSTRUCTIONS
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #20160: feat(explore): Add empty state to annotations
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #20160:
URL: https://github.com/apache/superset/pull/20160#discussion_r879549282
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx:
##########
@@ -98,6 +100,35 @@ const defaultProps = {
close: () => {},
};
+const NotFoundContentWrapper = styled.div`
+ && > div:first-child {
+ padding-left: 0;
+ padding-right: 0;
+ }
+`;
+
+const NotFoundContent = () => (
+ <NotFoundContentWrapper>
+ <EmptyStateSmall
+ title={t('No annotation layers')}
+ description={
+ <span>
+ {t('Add an annotation layer')}{' '}
+ <a
+ href="/annotationlayermodelview/list"
+ target="_blank"
+ rel="noopener noreferrer"
+ >
+ {t('here')}
+ </a>
Review Comment:
This isn't the only place where we have this type of translation logic, but splitting up a translation like this can be problematic for languages that have different sentence structure/order than English. But since I don't have a better proposal at this time we can surely live with this. But maybe there's a more modern translation library out there that more natively supports these types of Reacty-y use cases better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #20160: feat(explore): Add empty state to annotations
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #20160:
URL: https://github.com/apache/superset/pull/20160#discussion_r885541649
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx:
##########
@@ -98,6 +100,35 @@ const defaultProps = {
close: () => {},
};
+const NotFoundContentWrapper = styled.div`
+ && > div:first-child {
+ padding-left: 0;
+ padding-right: 0;
+ }
+`;
+
+const NotFoundContent = () => (
+ <NotFoundContentWrapper>
+ <EmptyStateSmall
+ title={t('No annotation layers')}
+ description={
+ <span>
+ {t('Add an annotation layer')}{' '}
+ <a
+ href="/annotationlayermodelview/list"
+ target="_blank"
+ rel="noopener noreferrer"
+ >
+ {t('here')}
+ </a>
Review Comment:
Interesting point. I'm not very familiar with the translation logic. Do you think it'd be a big project to switch to using this library?
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx:
##########
@@ -98,6 +100,35 @@ const defaultProps = {
close: () => {},
};
+const NotFoundContentWrapper = styled.div`
+ && > div:first-child {
+ padding-left: 0;
+ padding-right: 0;
+ }
+`;
+
+const NotFoundContent = () => (
+ <NotFoundContentWrapper>
+ <EmptyStateSmall
+ title={t('No annotation layers')}
+ description={
+ <span>
+ {t('Add an annotation layer')}{' '}
+ <a
+ href="/annotationlayermodelview/list"
+ target="_blank"
+ rel="noopener noreferrer"
+ >
+ {t('here')}
+ </a>
Review Comment:
Good point. I'm not very familiar with the translation logic. Do you think it'd be a big project to switch to using this library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #20160: feat(explore): Add empty state to annotations
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #20160:
URL: https://github.com/apache/superset/pull/20160#discussion_r879570775
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx:
##########
@@ -98,6 +100,35 @@ const defaultProps = {
close: () => {},
};
+const NotFoundContentWrapper = styled.div`
+ && > div:first-child {
+ padding-left: 0;
+ padding-right: 0;
+ }
+`;
+
+const NotFoundContent = () => (
+ <NotFoundContentWrapper>
+ <EmptyStateSmall
+ title={t('No annotation layers')}
+ description={
+ <span>
+ {t('Add an annotation layer')}{' '}
+ <a
+ href="/annotationlayermodelview/list"
+ target="_blank"
+ rel="noopener noreferrer"
+ >
+ {t('here')}
+ </a>
Review Comment:
..aaand some quick googling turned up this: https://react.i18next.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20160: feat(explore): Add empty state to annotations
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20160:
URL: https://github.com/apache/superset/pull/20160#issuecomment-1134807317
# [Codecov](https://codecov.io/gh/apache/superset/pull/20160?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20160](https://codecov.io/gh/apache/superset/pull/20160?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (96eedb0) into [master](https://codecov.io/gh/apache/superset/commit/b746e6f844d457d9a8c81d64e9154f315a61a29d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b746e6f) will **increase** coverage by `0.00%`.
> The diff coverage is `66.66%`.
> :exclamation: Current head 96eedb0 differs from pull request most recent head 253075f. Consider uploading reports for the commit 253075f to get more accurate results
```diff
@@ Coverage Diff @@
## master #20160 +/- ##
=======================================
Coverage 66.46% 66.46%
=======================================
Files 1721 1721
Lines 64521 64524 +3
Branches 6811 6811
=======================================
+ Hits 42882 42884 +2
- Misses 19906 19907 +1
Partials 1733 1733
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.34% <66.66%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/components/EmptyState/index.tsx](https://codecov.io/gh/apache/superset/pull/20160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRW1wdHlTdGF0ZS9pbmRleC50c3g=) | `76.19% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/20160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `60.71% <ø> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/20160/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `74.25% <66.66%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20160?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20160?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b746e6f...253075f](https://codecov.io/gh/apache/superset/pull/20160?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #20160: feat(explore): Add empty state to annotations
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #20160:
URL: https://github.com/apache/superset/pull/20160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org