You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by dr...@apache.org on 2015/01/16 02:54:46 UTC

directory-kerberos git commit: Updated some comments

Repository: directory-kerberos
Updated Branches:
  refs/heads/fixdes 83e1e0f08 -> ca2afc6b1


Updated some comments


Project: http://git-wip-us.apache.org/repos/asf/directory-kerberos/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-kerberos/commit/ca2afc6b
Tree: http://git-wip-us.apache.org/repos/asf/directory-kerberos/tree/ca2afc6b
Diff: http://git-wip-us.apache.org/repos/asf/directory-kerberos/diff/ca2afc6b

Branch: refs/heads/fixdes
Commit: ca2afc6b1fe75faabc9629e001deb5954f83b0b8
Parents: 83e1e0f
Author: Drankye <dr...@gmail.com>
Authored: Fri Jan 16 09:54:31 2015 +0800
Committer: Drankye <dr...@gmail.com>
Committed: Fri Jan 16 09:54:31 2015 +0800

----------------------------------------------------------------------
 .../org/apache/kerberos/kerb/crypto/EncryptionHandler.java   | 4 +---
 .../org/apache/kerberos/kerb/crypto/DesKeyMakerTest.java     | 8 +++++++-
 .../java/org/apache/kerberos/kerb/crypto/String2keyTest.java | 2 +-
 3 files changed, 9 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-kerberos/blob/ca2afc6b/haox-kerb/kerb-crypto/src/main/java/org/apache/kerberos/kerb/crypto/EncryptionHandler.java
----------------------------------------------------------------------
diff --git a/haox-kerb/kerb-crypto/src/main/java/org/apache/kerberos/kerb/crypto/EncryptionHandler.java b/haox-kerb/kerb-crypto/src/main/java/org/apache/kerberos/kerb/crypto/EncryptionHandler.java
index d393dfc..2d1d64e 100644
--- a/haox-kerb/kerb-crypto/src/main/java/org/apache/kerberos/kerb/crypto/EncryptionHandler.java
+++ b/haox-kerb/kerb-crypto/src/main/java/org/apache/kerberos/kerb/crypto/EncryptionHandler.java
@@ -47,9 +47,7 @@ public class EncryptionHandler {
 
     private static EncTypeHandler getEncHandler(EncryptionType eType, boolean check) throws KrbException {
         EncTypeHandler encHandler = null;
-        /**
-         * As it's still incomplete yet for the DesKeyMaker, commented DES_* types for now.
-         */
+
         switch (eType) {
             case DES_CBC_CRC:
                 encHandler = new DesCbcCrcEnc();

http://git-wip-us.apache.org/repos/asf/directory-kerberos/blob/ca2afc6b/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/DesKeyMakerTest.java
----------------------------------------------------------------------
diff --git a/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/DesKeyMakerTest.java b/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/DesKeyMakerTest.java
index cfc0032..ebc8055 100644
--- a/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/DesKeyMakerTest.java
+++ b/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/DesKeyMakerTest.java
@@ -5,6 +5,9 @@ import org.haox.util.HexUtil;
 import org.junit.Assert;
 import org.junit.Test;
 
+/**
+ * This is just for my experimental tweaking, so pleas bear it.
+ */
 public class DesKeyMakerTest {
 
     /**
@@ -48,7 +51,10 @@ public class DesKeyMakerTest {
         // finalKey check ignored here and it's done in String2keyTest.
     }
 
-    @Test
+    /**
+     * This is just for my experimental tweaking, so pleas bear it.
+     */
+    //@Test
     public void testCase1() {
         TestCase tc = new TestCase("ATHENA.MIT.EDUraeburn",
                 "password", "70617373776f7264415448454e412e4d49542e4544557261656275726e",

http://git-wip-us.apache.org/repos/asf/directory-kerberos/blob/ca2afc6b/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/String2keyTest.java
----------------------------------------------------------------------
diff --git a/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/String2keyTest.java b/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/String2keyTest.java
index f28b2d4..e2dd18c 100644
--- a/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/String2keyTest.java
+++ b/haox-kerb/kerb-crypto/src/test/java/org/apache/kerberos/kerb/crypto/String2keyTest.java
@@ -31,7 +31,7 @@ import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 /**
- * Based on MIT krb5 t_str2key.c
+ * By ref. MIT krb5 t_str2key.c and RFC3961 test vectors
  *
  * String 2 key test with known values.
  */