You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/03/07 17:08:21 UTC
Review Request 65954: Add a gauge for how long agent recovery takes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65954/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jason Lai.
Bugs: MESOS-8609
https://issues.apache.org/jira/browse/MESOS-8609
Repository: mesos
Description
-------
The new metric `slave/recover_secs` can be used to tell us how long
Mesos agent needed to finish its recovery cycle. This is an important
metric on agent machines which have a lot of completed executor
sandboxes.
Note that the metric 1) will only be available after recovery succeeded
and 2) never change its value across agent process lifecycle afterwards.
Diffs
-----
src/slave/metrics.hpp 3fc933ca65690d6fad63156398ad9c2c53789296
src/slave/metrics.cpp 0eb2b59ed67e14e73b29d7592c239441df0008d5
src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70
Diff: https://reviews.apache.org/r/65954/diff/1/
Testing
-------
Thanks,
Zhitao Li