You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "allthingssecurity (via GitHub)" <gi...@apache.org> on 2026/10/08 00:07:15 UTC

[PR] CAMEL-25356: camel-cm-sms - recognize <, >, the currency sign and form feed as GSM 03.38 characters [camel]

allthingssecurity opened a new pull request, #27531:
URL: https://github.com/apache/camel/pull/27531

   # Description
   
   [CAMEL-25356](https://issues.apache.org/jira/browse/CAMEL-25356)
   
   `CMConstants.GSM_0338_REGEX` contained the HTML entities `&amp;`, `&lt;`, `&gt;` of the page it was copied from, so `<` and `>` were not in the character class; `ยค` (GSM default alphabet) and form feed (extension table) were missing too. Messages with these characters were sent as unicode (DCS 8) with 70/67 characters per part, and the maximum number of parts was computed for unicode (310 characters: 5 parts instead of 3).
   
   This change writes the characters themselves in the class. Every message that matched before still matches; messages with these characters are now sent as GSM, in fewer parts, which the new `=== camel-cm-sms - GSM 03.38 detection` section of the 4.23 upgrade guide says.
   
   Tests: new `CMGsm0338Test` (all GSM 03.38 characters, a text with `<` and `>`), all three fail without the change; module: 54 tests pass.
   
   Found with a Lean 4 model of the class against the GSM 03.38 table: exactly `ยค < >` and form feed are missing on main, and the class of the fix is exactly GSM 03.38.
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
   
   # Tracking
   - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful subject line and body.
   - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
     (I built and tested the affected module, including the formatter and import-sort plugins. I did not run the full root build.)
   
   # AI-assisted contributions
   
   - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used.
     This PR was prepared with Claude Code (Claude Opus 5.5). The commit carries a `Co-Authored-By` trailer.
   
   _Claude Code on behalf of allthingssecurity_
   
   ๐Ÿค– Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-25356: camel-cm-sms - recognize <, >, the currency sign and form feed as GSM 03.38 characters [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #27531:
URL: https://github.com/apache/camel/pull/27531


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-25356: camel-cm-sms - recognize <, >, the currency sign and form feed as GSM 03.38 characters [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27531:
URL: https://github.com/apache/camel/pull/27531#issuecomment-6053624002

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-cm-sms`
   - `docs`
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison โ€” Scalpel: 9 of 700 tested, 26 compile-only โ€” current: 9 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **9 affected modules** (current approach: 9).
   
   **Skip-tests mode would test 9 modules** (2 direct + 8 downstream), **skip tests for 26** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (9)</summary>
   
   - `camel-cm-sms` โ† components/camel-cm-sms/src/main/java/org/apache/camel/component/cm/CMConstants.java, components/camel-cm-sms/src/test/java/org/apache/camel/component/cm/test/CMGsm0338Test.java
   - `camel-jbang-mcp` โ† downstream of org.apache.camel:camel-catalog
   - `camel-jbang-plugin-mcp` โ† downstream of org.apache.camel:camel-jbang-core
   - `camel-jbang-plugin-route-parser` โ† downstream of org.apache.camel:camel-route-parser
   - `camel-jbang-plugin-tui` โ† downstream of org.apache.camel:camel-catalog
   - `camel-jbang-plugin-validate` โ† downstream of org.apache.camel:camel-yaml-dsl-validator
   - `camel-launcher-container` โ† downstream of org.apache.camel:camel-launcher
   - `camel-yaml-dsl-validator` โ† downstream of org.apache.camel:camel-catalog
   - `camel-yaml-dsl-validator-maven-plugin` โ† downstream of org.apache.camel:camel-yaml-dsl-validator
   
   </details>
   
   <details><summary>Modules with tests skipped (26)</summary>
   
   - `apache-camel`
   - `camel-allcomponents`
   - `camel-catalog`
   - `camel-catalog-console`
   - `camel-catalog-maven`
   - `camel-catalog-suggest`
   - `camel-componentdsl`
   - `camel-endpointdsl`
   - `camel-endpointdsl-support`
   - `camel-itest`
   - `camel-jbang-core`
   - `camel-jbang-it`
   - `camel-jbang-main`
   - `camel-jbang-plugin-edit`
   - `camel-jbang-plugin-generate`
   - `camel-jbang-plugin-kubernetes`
   - `camel-jbang-plugin-test`
   - `camel-kamelet-main`
   - `camel-launcher`
   - `camel-report-maven-plugin`
   - `camel-route-parser`
   - `camel-yaml-dsl`
   - `camel-yaml-dsl-deserializers`
   - `camel-yaml-dsl-maven-plugin`
   - `coverage`
   - `dummy-component`
   
   </details>
   
   > :information_source: Shadow mode โ€” Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   <details><summary>All tested modules (36 modules, 6m 16s total)</summary>
   
   **Total reactor time:** 6m 16s
   
   | Module | Duration | Status |
   | --- | --- | --- |
   | Camel :: Launcher | 53.2s | SUCCESS |
   | Camel :: JBang :: Plugin :: TUI | 45.3s | SUCCESS |
   | Camel :: JBang :: MCP | 41.7s | SUCCESS |
   | Camel :: Catalog :: Camel Catalog | 24.2s | SUCCESS |
   | Camel :: Component DSL | 23.2s | SUCCESS |
   | Camel :: YAML DSL :: Validator | 21.1s | SUCCESS |
   | Camel :: YAML DSL | 19.7s | SUCCESS |
   | Camel :: CM SMS | 17.6s | SUCCESS |
   | Camel :: JBang :: Plugin :: Validate | 16.2s | SUCCESS |
   | Camel :: Docs | 15.9s | SUCCESS |
   | Camel :: JBang :: Plugin :: Testing | 14.2s | SUCCESS |
   | Camel :: JBang :: Plugin :: Kubernetes | 12.4s | SUCCESS |
   | Camel :: Kamelet Main | 12.2s | SUCCESS |
   | Camel :: YAML DSL :: Deserializers | 8.0s | SUCCESS |
   | Camel :: Catalog :: Camel Route Parser | 7.8s | SUCCESS |
   | Camel :: Catalog :: Camel Report Maven Plugin | 6.6s | SUCCESS |
   | Camel :: YAML DSL :: Validator Maven Plugin | 6.4s | SUCCESS |
   | Camel :: All Components Sync point | 5.6s | SUCCESS |
   | Camel :: Catalog :: Maven | 3.6s | SUCCESS |
   | Camel :: YAML DSL :: Maven Plugins | 3.3s | SUCCESS |
   | Camel :: Catalog :: Suggest (deprecated) | 2.7s | SUCCESS |
   | Camel :: Coverage | 2.4s | SUCCESS |
   | Camel :: JBang :: Plugin :: Edit | 2.1s | SUCCESS |
   | Camel :: Assembly | 1.7s | SUCCESS |
   | Camel :: JBang :: Plugin :: Generate | 1.3s | SUCCESS |
   | Camel :: Catalog :: Dummy Component | 1.3s | SUCCESS |
   | Camel :: JBang :: Integration tests | 1.0s | SUCCESS |
   | Camel :: JBang :: Plugin :: MCP | 0.9s | SUCCESS |
   | Camel :: Catalog :: Console | 0.9s | SUCCESS |
   | Camel :: Endpoint DSL :: Support | 0.8s | SUCCESS |
   | Camel :: JBang :: Main | 0.8s | SUCCESS |
   | Camel :: Launcher :: Container | 0.7s | SUCCESS |
   | Camel :: JBang :: Plugin :: Route Parser | 0.7s | SUCCESS |
   | Camel :: Endpoint DSL | n/a |  |
   | Camel :: Integration Tests | n/a |  |
   | Camel :: JBang :: Core | n/a |  |
   
   **Top 20 slowest modules:**
   - `Camel :: Launcher` (53.2s)
   - `Camel :: JBang :: Plugin :: TUI` (45.3s)
   - `Camel :: JBang :: MCP` (41.7s)
   - `Camel :: Catalog :: Camel Catalog` (24.2s)
   - `Camel :: Component DSL` (23.2s)
   - `Camel :: YAML DSL :: Validator` (21.1s)
   - `Camel :: YAML DSL` (19.7s)
   - `Camel :: CM SMS` (17.6s)
   - `Camel :: JBang :: Plugin :: Validate` (16.2s)
   - `Camel :: Docs` (15.9s)
   - `Camel :: JBang :: Plugin :: Testing` (14.2s)
   - `Camel :: JBang :: Plugin :: Kubernetes` (12.4s)
   - `Camel :: Kamelet Main` (12.2s)
   - `Camel :: YAML DSL :: Deserializers` (8.0s)
   - `Camel :: Catalog :: Camel Route Parser` (7.8s)
   - `Camel :: Catalog :: Camel Report Maven Plugin` (6.6s)
   - `Camel :: YAML DSL :: Validator Maven Plugin` (6.4s)
   - `Camel :: All Components Sync point` (5.6s)
   - `Camel :: Catalog :: Maven` (3.6s)
   - `Camel :: YAML DSL :: Maven Plugins` (3.3s)
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/37706042223)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-25356: camel-cm-sms - recognize <, >, the currency sign and form feed as GSM 03.38 characters [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27531:
URL: https://github.com/apache/camel/pull/27531#issuecomment-6053222323

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org