You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/09/12 06:32:55 UTC
[kudu-CR] [iwyu] add catalog manager.{cc,h} files
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11430
Change subject: [iwyu] add catalog_manager.{cc,h} files
......................................................................
[iwyu] add catalog_manager.{cc,h} files
Removed catalog_manager.{cc,h} files from the IWYU's black list.
It seems at this point the IWYU tool no longer outputs conflicting
suggestions.
Change-Id: I3b65dc90a5e6378286e51fcfdcdefdf499fbd89c
---
M build-support/iwyu.py
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
3 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/11430/1
--
To view, visit http://gerrit.cloudera.org:8080/11430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b65dc90a5e6378286e51fcfdcdefdf499fbd89c
Gerrit-Change-Number: 11430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [iwyu] add catalog manager.{cc,h} files
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11430 )
Change subject: [iwyu] add catalog_manager.{cc,h} files
......................................................................
[iwyu] add catalog_manager.{cc,h} files
Removed catalog_manager.{cc,h} files from the IWYU's black list.
It seems at this point the IWYU tool no longer outputs conflicting
suggestions.
Change-Id: I3b65dc90a5e6378286e51fcfdcdefdf499fbd89c
Reviewed-on: http://gerrit.cloudera.org:8080/11430
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/iwyu.py
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
3 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b65dc90a5e6378286e51fcfdcdefdf499fbd89c
Gerrit-Change-Number: 11430
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [iwyu] add catalog manager.{cc,h} files
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11430 )
Change subject: [iwyu] add catalog_manager.{cc,h} files
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b65dc90a5e6378286e51fcfdcdefdf499fbd89c
Gerrit-Change-Number: 11430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 12 Sep 2018 06:37:14 +0000
Gerrit-HasComments: No