You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/18 05:52:27 UTC
[GitHub] [arrow] cyb70289 opened a new pull request #7476: ARROW-9168: [C++][Flight] configure TCP connection sharing in benchmark
cyb70289 opened a new pull request #7476:
URL: https://github.com/apache/arrow/pull/7476
Flight benchmark performs worse when working threads increases. It can
be improved by setting gRPC option GRPC_ARG_USE_LOCAL_SUBCHANNEL_POOL
to make each client creating its own TCP connection to server, without
sharing one connection.
This patch adds a cmdline parameter to configure TCP connection sharing.
Default behaviour is to separate connection, which performs better when
working threads increases.
This patch also changes parameter "records_per_stream" from int32 to
int64, to ease profiling by setting it to a very large value and keep
benchmark running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7476: ARROW-9168: [C++][Flight] configure TCP connection sharing in benchmark
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7476:
URL: https://github.com/apache/arrow/pull/7476#issuecomment-645928473
I think we could simply enable this option by default in the Flight client. Sharing the same TCP connection for all Flight clients doesn't like a good idea at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7476: ARROW-9168: [C++][Flight] Don't share TCP connection among clients
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7476:
URL: https://github.com/apache/arrow/pull/7476#issuecomment-646094205
Thank you @cyb70289 !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7476: ARROW-9168: [C++][Flight] configure TCP connection sharing in benchmark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7476:
URL: https://github.com/apache/arrow/pull/7476#issuecomment-645797333
https://issues.apache.org/jira/browse/ARROW-9168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7476: ARROW-9168: [C++][Flight] configure TCP connection sharing in benchmark
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7476:
URL: https://github.com/apache/arrow/pull/7476#issuecomment-645984765
> @lidavidm Looks we need another level of abstraction above flight client `generic_options`. Otherwise, we have to expose grpc constants(backend implementation) to client code. See TODO in this patch.
The intent of the option _is_ to expose gRPC-specific options and not have to abstract them away; there are lots of options and there's no point keeping up with all of them. This option is entirely backend-dependent and would be pointless on a non-gRPC implementation.
> I think we could simply enable this option by default in the Flight client. Sharing the same TCP connection for all Flight clients doesn't like a good idea at all.
I think that makes sense for this option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #7476: ARROW-9168: [C++][Flight] configure TCP connection sharing in benchmark
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #7476:
URL: https://github.com/apache/arrow/pull/7476#issuecomment-645844973
@lidavidm Looks we need another level of abstraction above flight client `generic_options`. Otherwise, we have to expose grpc constants(backend implementation) to client code. See TODO in this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #7476: ARROW-9168: [C++][Flight] Don't share TCP connection among clients
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #7476:
URL: https://github.com/apache/arrow/pull/7476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org