[GitHub] [commons-imaging] gwlucastrig commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)

[GitBox <gi...@apache.org>]

gwlucastrig commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-766068067


   I need a bit more time to review this, but one thing occurs to me right away.  In the TIFF standard, there are a number of special data formats and bit-packing sequences (T4 fax, etc.) that are unique to TIFF and some that are similar to other formats.  Also, I am not sure that Commons Imaging supports all the TIFF options.  So having an enumerated type specific to the TIFF package makes sense for that purpose because it serves as a kind of documentation of what is done (values included in the enumeration) and what still needs to be done (values not found in the enumeration).   I'm not sure about compression type (LZW versus Zip, etc.), but that could be the same kind of thing. 
   
   On the other hand, there are other a few options that are common to all or many graphics formats (indexed color model versus RGB versus CMYK, etc.).  So I would agree that those go in the common package.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org