[jira] [Commented] (HTRACE-279) Force HTraced span receiver to use SpanSerializer and add validation to htraced REST ingest path

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955797#comment-14955797 ] 

Colin Patrick McCabe commented on HTRACE-279:
---------------------------------------------

I'm not sure why this happens in some build environments but not others.  We have gotten complaints in the past about Jackson being flaky about serializing Spans in submodules other than htrace-core, and this seems like just another example.  Let's explicitly request that we want the {{SpanSerializer}}.

> Force HTraced span receiver to use SpanSerializer and add validation to htraced REST ingest path
> ------------------------------------------------------------------------------------------------
>
>                 Key: HTRACE-279
>                 URL: https://issues.apache.org/jira/browse/HTRACE-279
>             Project: HTrace
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>
> Apparently the HTracedReceiver is sometimes not using the JSON SpanSerializer from htrace-core4.  We should force the span receiver to use that serializer.  Also, we should add span ID validation to the htraced daemon.  Currently, a bad span ID can crash the daemon, which is not very robust.  These changes will fix the unit test failure in TestHTracedReceiver.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)