You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/30 08:07:32 UTC
[GitHub] [airflow] potiuk opened a new pull request #15611: Remove the limit on Gunicorn constraint.
potiuk opened a new pull request #15611:
URL: https://github.com/apache/airflow/pull/15611
It seems that the < 20.0 limit for gunicorn was added at some point
in time without actual reason. We are already using gunicorn in
1.10 line of Airflow, so it should not be a problem to bump the
version of gunicorn, especially that the 19. line is somewhat
deprecated already.
This change came after the discussion n #15570
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15611: Remove the limit on Gunicorn dependency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15611:
URL: https://github.com/apache/airflow/pull/15611#issuecomment-830199165
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15611: Remove the limit on Gunicorn dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15611:
URL: https://github.com/apache/airflow/pull/15611#issuecomment-830171610
Agree with @uranusjr - our constraints approach is designed to prevent precisely this problem and it works with most of our dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #15611: Remove the limit on Gunicorn dependency
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #15611:
URL: https://github.com/apache/airflow/pull/15611#issuecomment-830115209
Looks like all tests are passing with gunicorn 20.1.0 (the latest one). I tested it locally as well, and everything seems to be fine Airflow works with several gunicorn workers - looks like no problems. I think we can safely merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15611: Remove the limit on Gunicorn dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15611:
URL: https://github.com/apache/airflow/pull/15611#issuecomment-830115209
Looks like all tests are passing with gunicorn 20.1.0 (the latest one). I tested it locally as well, and everything seems to be fine Airflow works with several gunicorn workers - looks like no major problems. I think we can safely merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15611: Remove the limit on Gunicorn dependency
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15611:
URL: https://github.com/apache/airflow/pull/15611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #15611: Remove the limit on Gunicorn dependency
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #15611:
URL: https://github.com/apache/airflow/pull/15611#issuecomment-830125125
That's when the constraints files is useful 🙂 Python packaging encourages the "compatible unless proven guilty" approach since it's much easier for the user to add extra constraints if gunicorn 22 proves incompatible, but it's much more difficult to remove `gunicorn<22` if it causes unnecessarily conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org