You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/14 13:00:56 UTC

[GitHub] [camel] rnetuka opened a new pull request, #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

rnetuka opened a new pull request, #8553:
URL: https://github.com/apache/camel/pull/8553

   Issue: https://issues.apache.org/jira/browse/CAMEL-18612
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1278980945

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] rnetuka commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
rnetuka commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1280597140

   @davsclaus I've added a unit test. Without the changes, it throws an error. With the changes, it works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1280700052

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 11 | 11 | 2 | 10 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1280850638

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 11 | 11 | 2 | 10 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] rnetuka commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
rnetuka commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1282491553

   Based on the JIRA discussion, this has been replaced by https://github.com/apache/camel/pull/8571 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1279690206

   Is there an unit test that can reproduce this that can be added to camel-jsonpath. As a PR that removes code claiming to fix a bug, then I would like to see if possible a testcase for such bug first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] rnetuka commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
rnetuka commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1279014327

   @oscerd I doubt this corner case ever was supported. When I try the reproducer from the issue, the list element unwraps as a LinkedHashMap and a type converter calls LinkedHashMap#toString to create the return value, which is not a valid Json string.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] rnetuka closed pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
rnetuka closed pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
URL: https://github.com/apache/camel/pull/8553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1279034480

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 1 | 0 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] oscerd commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1278997943

   As far as It seems there is no specific needs for that, but maybe I would git blame around to find something. Maybe there is some specific reason or something we don't need anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] rnetuka commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
rnetuka commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1278995713

   @oscerd nothing, the result will be a list with a single element. A one-element list is still a list in my opinion. Is there some case when you actually _need_ the unwrapping?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8553: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8553:
URL: https://github.com/apache/camel/pull/8553#issuecomment-1280701140

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 11 | 11 | 2 | 10 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org