You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/04 00:17:49 UTC
[GitHub] [tvm] gromero opened a new pull request #10479: [microTVM] Zephyr: add mps3_an547 board support
gromero opened a new pull request #10479:
URL: https://github.com/apache/tvm/pull/10479
Add mps3_an547 board support to microTVM.
On Zephyr this board is supported by two emulators: QEMU and FVP. This
commit only enables the support for running mps3_an547 on QEMU, since
currently there isn't a FVP transporter on microTVM. The main difference
between these two emulation is that FVP is provided by ARM as closed
source emulator (although otoh it supports Ethos-U55 accelerator). Thus
support for FVP will handled later.
The mps3_an547 is a reference board. For more details, please see:
https://developer.arm.com/tools-and-software/development-boards/fpga-prototyping-boards/mps3
Signed-off-by: Gustavo Romero <gu...@linaro.org>
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #10479: [microTVM] Zephyr: add mps3_an547 board support
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #10479:
URL: https://github.com/apache/tvm/pull/10479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on a change in pull request #10479: [microTVM] Zephyr: add mps3_an547 board support
Posted by GitBox <gi...@apache.org>.
gromero commented on a change in pull request #10479:
URL: https://github.com/apache/tvm/pull/10479#discussion_r825964726
##########
File path: apps/microtvm/zephyr/template_project/boards.json
##########
@@ -23,6 +23,14 @@
"vid_hex": "",
"pid_hex": ""
},
+ "mps3_an547": {
+ "board": "mps3_an547",
+ "model": "mps3_an547",
+ "is_qemu": true,
+ "fpu": false,
+ "vid_hex": "",
+ "pid_hex": ""
Review comment:
@mehrdadh Absolutely. Done. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #10479: [microTVM] Zephyr: add mps3_an547 board support
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #10479:
URL: https://github.com/apache/tvm/pull/10479#issuecomment-1066821444
cc @mkatanbaf fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a change in pull request #10479: [microTVM] Zephyr: add mps3_an547 board support
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on a change in pull request #10479:
URL: https://github.com/apache/tvm/pull/10479#discussion_r825206165
##########
File path: apps/microtvm/zephyr/template_project/boards.json
##########
@@ -23,6 +23,14 @@
"vid_hex": "",
"pid_hex": ""
},
+ "mps3_an547": {
+ "board": "mps3_an547",
+ "model": "mps3_an547",
+ "is_qemu": true,
+ "fpu": false,
+ "vid_hex": "",
+ "pid_hex": ""
Review comment:
Can you add "note" here and mention why `fpu` is set to false?
something like this: https://github.com/apache/tvm/blob/main/apps/microtvm/arduino/template_project/boards.json#L15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #10479: [microTVM] Zephyr: add mps3_an547 board support
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #10479:
URL: https://github.com/apache/tvm/pull/10479#issuecomment-1068006991
@leandron @alanmacd @mehrdadh Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #10479: [microTVM] Zephyr: add mps3_an547 board support
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #10479:
URL: https://github.com/apache/tvm/pull/10479#issuecomment-1065678913
cc @areusch @mehrdadh @alanmacd @leandron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org