[GitHub] [tinkerpop] dkuppitz commented on issue #1120: gt/gte/lt/lte can throw CCE if object isn't a Comparable

[GitBox <gi...@apache.org>]

dkuppitz commented on issue #1120: gt/gte/lt/lte can throw CCE if object isn't a Comparable
URL: https://github.com/apache/tinkerpop/pull/1120#issuecomment-496541823
 
 
   I don't like this change too much, I'd prefer to get the CCE.
   
   Simple example:
   
   ```
   gremlin> g = TinkerFactory.createModern().traversal()
   ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
   gremlin> g.V(1).as("a").out().where(gt("a")).by("name").by("age")
   java.lang.Integer cannot be cast to java.lang.String
   Type ':help' or ':h' for help.
   Display stack trace? [yN]
   ```
   
   Now, I've seen enough users who forgot to do the conversion from `String` to `Integer` when the load their data. Without the CCE they will have a hard time figuring out why the result is always empty.
   
   I dunno, I'd rather give a -1 on this one, but if others feel like this is the corrected behavior, I wouldn't mind getting it merged. Hence:
   
   VOTE +/-0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services