You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/30 07:42:24 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #18061: Remove schema from some DistSQL result sets.
RaigorJiang opened a new pull request, #18061:
URL: https://github.com/apache/shardingsphere/pull/18061
Remove schema from DistSQL result sets:
- ShardingTableRulesUsedAlgorithmQueryResultSet
- ShardingTableRulesUsedKeyGeneratorQueryResultSet
### Before
```sql
mysql> SHOW SHARDING TABLE RULES USED ALGORITHM order_inline;
+-------------+-------+---------+
| schema | type | name |
+-------------+-------+---------+
| sharding_db | table | t_order |
+-------------+-------+---------+
1 row in set (0.00 sec)
mysql> SHOW SHARDING TABLE RULES USED KEY GENERATOR snowflake;
+-------------+-------+---------+
| schema | type | name |
+-------------+-------+---------+
| sharding_db | table | t_order |
+-------------+-------+---------+
1 row in set (0.01 sec)
```
### After
```sql
mysql> SHOW SHARDING TABLE RULES USED ALGORITHM order_inline;
+-------+---------+
| type | name |
+-------+---------+
| table | t_order |
+-------+---------+
1 row in set (0.27 sec)
mysql> SHOW SHARDING TABLE RULES USED KEY GENERATOR snowflake;
+-------+---------+
| type | name |
+-------+---------+
| table | t_order |
+-------+---------+
1 row in set (0.01 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18061: Remove schema from some DistSQL result sets.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18061:
URL: https://github.com/apache/shardingsphere/pull/18061#issuecomment-1140850241
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18061?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18061](https://codecov.io/gh/apache/shardingsphere/pull/18061?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ceed369) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a159040ed39eb26838fc236f1e99c8ff22c4f336?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a159040) will **not change** coverage.
> The diff coverage is `75.00%`.
> :exclamation: Current head ceed369 differs from pull request most recent head a8464c9. Consider uploading reports for the commit a8464c9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #18061 +/- ##
=========================================
Coverage 58.94% 58.94%
Complexity 2152 2152
=========================================
Files 3671 3671
Lines 54124 54124
Branches 9185 9185
=========================================
Hits 31903 31903
Misses 19515 19515
Partials 2706 2706
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ShardingTableRulesUsedAlgorithmQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/18061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9TaGFyZGluZ1RhYmxlUnVsZXNVc2VkQWxnb3JpdGhtUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `66.66% <75.00%> (ø)` | |
| [...rdingTableRulesUsedKeyGeneratorQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/18061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9TaGFyZGluZ1RhYmxlUnVsZXNVc2VkS2V5R2VuZXJhdG9yUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `69.56% <75.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18061?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18061?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a159040...a8464c9](https://codecov.io/gh/apache/shardingsphere/pull/18061?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #18061: Remove schema from some DistSQL result sets.
Posted by GitBox <gi...@apache.org>.
zjcnb merged PR #18061:
URL: https://github.com/apache/shardingsphere/pull/18061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org