[GitHub] [camel-kamelets] igarashitm opened a new issue, #1475: Bean: Use `properties` instead of `property` with `key` and `value`

["igarashitm (via GitHub)" <gi...@apache.org>]

igarashitm opened a new issue, #1475:
URL: https://github.com/apache/camel-kamelets/issues/1475

   I found some kamelets are using `beans` `property` with `key` and `value` style, for example
   https://github.com/apache/camel-kamelets/blob/main/kamelets/mysql-sink.kamelet.yaml#L97-L108
   
   But the schema doesn't allow it. `RouteTemplateDefinition` specifies `NamedBeanDefinition` for `beans`
   https://github.com/apache/camel/blob/camel-3.20.x/dsl/camel-yaml-dsl/camel-yaml-dsl/src/generated/resources/schema/camel-yaml-dsl.json#LL2621C40-L2621C40
   
   where `NamedBeanDefinition` has only `properties` with the type `object`
   https://github.com/apache/camel/blob/camel-3.20.x/dsl/camel-yaml-dsl/camel-yaml-dsl/src/generated/resources/schema/camel-yaml-dsl.json#L339
   
   Once `additionalProperties: false` is added to the schema (which is on table for doing on Camel4), this could end up with validation error. We'd want to align with schema before it happens.
   
   Cc: @lburgazzoli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kamelets] oscerd closed issue #1475: Bean: Use `properties` instead of `property` with `key` and `value`

["oscerd (via GitHub)" <gi...@apache.org>]

oscerd closed issue #1475: Bean: Use `properties` instead of `property` with `key` and `value`
URL: https://github.com/apache/camel-kamelets/issues/1475


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-kamelets] oscerd commented on issue #1475: Bean: Use `properties` instead of `property` with `key` and `value`

["oscerd (via GitHub)" <gi...@apache.org>]

oscerd commented on issue #1475:
URL: https://github.com/apache/camel-kamelets/issues/1475#issuecomment-1562953490

   Should be fine now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org