You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ascheman (via GitHub)" <gi...@apache.org> on 2026/06/13 20:33:21 UTC

[PR] WarnChecksumPolicy: proceed on no checksums [maven-resolver]

ascheman opened a new pull request, #1922:
URL: https://github.com/apache/maven-resolver/pull/1922

   Draft / one shape for discussion — fixes the minimal manifestation of
   apache/maven-resolver#1920 while leaving the larger design question open
   for `dev@maven.apache.org`.
   
   ## Change
   
   Override `AbstractChecksumPolicy.onNoMoreChecksums()` in
   `WarnChecksumPolicy` so it logs a warning and returns, instead of
   inheriting the unconditional `ChecksumFailureException` throw.
   
   `FailChecksumPolicy` is unchanged: it continues to throw via the
   inherited base behavior.
   
   `WarnChecksumPolicyTest.testOnNoMoreChecksums()` updated to assert the
   new behavior (no exception).
   
   ## Scope and framing
   
   This is the smallest possible patch that addresses #1920's reported
   behavior. It does **not** touch:
   
   - the default behavior for repos without an explicit `<checksumPolicy>`
   - `file://` vs HTTP transport semantics
   - the broader checksum-policy-controls space being redesigned in
     #1782 / #1784 / #1917
   
   Other shapes (transport-aware default in `DefaultChecksumPolicyProvider`,
   new opt-in property like `aether.checksums.noChecksumsOutcome` analogous
   to RRF's `noInputOutcome`, Maven 4 compatibility-mode flag) are
   discussed separately on `dev@maven.apache.org`. **Marking as draft so
   the maintainer can decide whether this minimal shape is the right one,
   or whether a broader change is preferred.**
   
   ## Verification
   
   - New `WarnChecksumPolicyTest.testOnNoMoreChecksums()` passes locally
     (JDK 21, Maven 3.9.16, `2.0.19-SNAPSHOT`).
   - Full `maven-resolver-impl` test suite passes locally.
   
   cc @cstamas
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WarnChecksumPolicy: proceed on no checksums [maven-resolver]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1922:
URL: https://github.com/apache/maven-resolver/pull/1922#issuecomment-4701816092

   @cstamas Please assign appropriate label to PR according to the type of change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WarnChecksumPolicy: proceed on no checksums [maven-resolver]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1922:
URL: https://github.com/apache/maven-resolver/pull/1922


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WarnChecksumPolicy: proceed on no checksums [maven-resolver]

Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on PR #1922:
URL: https://github.com/apache/maven-resolver/pull/1922#issuecomment-4699795858

   > @ascheman Sorry, was faster 😄 please take a peek at other PR and let's reconcile both PRs, as I perso like better your message!
   
   Thanks!
   
   I intentionally started this as draft as I think there are other opportunities (larger ones, check the mail I just sent to dev Mailinglist). Nevertheless, this could be a good first approximation of a solution which we might merge until something better comes up? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WarnChecksumPolicy: proceed on no checksums [maven-resolver]

Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on PR #1922:
URL: https://github.com/apache/maven-resolver/pull/1922#issuecomment-4701340748

   > This is still draft, on purpose?
   
   Yes, did you see my mail on the dev list? I see the two opportunities:
   - Just merge it and have a quick fix
   - Consider a longer solution in the course of your anticipated redesign of resolver?
   
   For the sake of simplicity (and speed), I would suggest, to merge it now and think about a more general solution later.
   
   Having said that, I will now make it ready and leave it to you to merge now or discuss other solutions first.
   // @hboutemy who also asked already about the more elaborated solutions proposed on the mailing list (which seem to make it unnecessary complex in this very moment).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WarnChecksumPolicy: proceed on no checksums [maven-resolver]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1922:
URL: https://github.com/apache/maven-resolver/pull/1922#issuecomment-4699735125

   @ascheman Sorry, was faster :smile:  please take a peek at other PR and let's reconcile both PRs, as I perso like better your message!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WarnChecksumPolicy: proceed on no checksums [maven-resolver]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1922:
URL: https://github.com/apache/maven-resolver/pull/1922#issuecomment-4701814315

   I will merge this as "least painful" thing, and latest can discuss, want 2.0.19 out ASAP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WarnChecksumPolicy: proceed on no checksums [maven-resolver]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1922:
URL: https://github.com/apache/maven-resolver/pull/1922#issuecomment-4701289875

   This is still draft, on purpose?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org