You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2016/03/28 13:52:25 UTC

[jira] [Created] (LUCENE-7145) We need only one set of polygon util methods

Robert Muir created LUCENE-7145:
-----------------------------------

             Summary: We need only one set of polygon util methods
                 Key: LUCENE-7145
                 URL: https://issues.apache.org/jira/browse/LUCENE-7145
             Project: Lucene - Core
          Issue Type: Bug
            Reporter: Robert Muir


LatLonPoint methods are calling {{*precise()}} methods such as rectCrossesPolyPrecise(). GeoPointMethods are calling {{*approx()}} methods such as rectCrossesPolyApprox().

I don't understand why we have two versions of these methods, why one is approximate, why we would ever use that, etc.

These geo methods are extremely expensive: we can't afford two copies. For example, in the case of these polygon methods, they are still missing direct tests. We need to remove one copy of these. I propose to remove the approx ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org