You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/11/04 15:33:44 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3317: STORM-3682 Upgrade netty client metrics to use V2 API

Ethanlm commented on a change in pull request #3317:
URL: https://github.com/apache/storm/pull/3317#discussion_r517431135



##########
File path: storm-client/src/jvm/org/apache/storm/messaging/IContext.java
##########
@@ -29,8 +30,11 @@
      * This method is invoked at the startup of messaging plugin.
      *
      * @param topoConf storm configuration
+     * @param metricRegistry metric registry
+     * @param topologyId topology Id
+     * @param workerPort worker port
      */
-    void prepare(Map<String, Object> topoConf);
+    void prepare(Map<String, Object> topoConf, StormMetricRegistry metricRegistry, String topologyId, int workerPort);

Review comment:
       I guess it should work. I don't have a better way at this moment. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org