You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2019/02/01 20:25:00 UTC
[jira] [Updated] (HBASE-20837) Make IDE configuration for import
order match that in our checkstyle module
[ https://issues.apache.org/jira/browse/HBASE-20837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-20837:
-----------------------------------
Fix Version/s: (was: 2.2.0)
(was: 1.5.0)
(was: 3.0.0)
> Make IDE configuration for import order match that in our checkstyle module
> ---------------------------------------------------------------------------
>
> Key: HBASE-20837
> URL: https://issues.apache.org/jira/browse/HBASE-20837
> Project: HBase
> Issue Type: Improvement
> Components: community
> Affects Versions: 3.0.0, 2.0.1, 1.4.5
> Reporter: Tak Lon (Stephen) Wu
> Assignee: Tak Lon (Stephen) Wu
> Priority: Minor
> Attachments: HBASE-20837.branch-1.001.patch, HBASE-20837.branch-1.002.patch, HBASE-20837.branch-1.003.patch, HBASE-20837.branch-2.001.patch, HBASE-20837.branch-2.002.patch, HBASE-20837.branch-2.003.patch, HBASE-20837.master.001.patch, HBASE-20837.master.002.patch, HBASE-20837.master.003.patch, IDEA import layout.png, hbase-intellij-formatter.xml
>
>
> While working on HBASE-20557 contribution, we figured out that the checkstyle build target (ImportOrder's `groups` [http://checkstyle.sourceforge.net/config_imports.html] ) was different from the development supported IDE (e.g. IntelliJ and Eclipse) formatter, we would provide a fix here to sync between [dev-support/hbase_eclipse_formatter.xml|https://github.com/apache/hbase/blob/master/dev-support/hbase_eclipse_formatter.xml] and [hbase/checkstyle.xml|https://github.com/apache/hbase/blob/master/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml]
> This might need to backport the changes of master to branch-1 and branch-2 as well.
> Before this change, this is what checkstyle is expecting for import order
>
> {code:java}
> import com.google.common.annotations.VisibleForTesting;
> import java.io.IOException;
> import java.util.ArrayList;
> import java.util.List;
> import java.util.Map;
> import org.apache.commons.logging.Log;
> import org.apache.commons.logging.LogFactory;
> import org.apache.hadoop.conf.Configuration;
> import org.apache.hadoop.hbase.classification.InterfaceAudience;
> import org.apache.hadoop.hbase.conf.ConfigurationObserver;{code}
>
> And the proposed import order with the respect to HBASE-19262 and HBASE-19552 should be
>
> !IDEA import layout.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)