You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/27 14:58:13 UTC
[GitHub] [lucene-solr] epugh opened a new pull request #2436: SOLR-15161: Lets not encourage users to hack mime types on JSON responses.
epugh opened a new pull request #2436:
URL: https://github.com/apache/lucene-solr/pull/2436
# Description
Browsers now care if you are doing a JSONP call and they expect application/json, and block any text/plain mime type response.
In Quepid we communicate the API command to update your JSONResponseWriter during your setup process, but it's still very confusing. It was a "cool hack" back when we first used it, but 10 years later, it's causing issues.
# Solution
Remove hack, and add warning in the docs if you choose to do it.
# Tests
Reran tests.
# Checklist
Please review the following and check all that apply:
- [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ X] I have created a Jira issue and added the issue ID to my pull request title.
- [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ X] I have developed this patch against the `master` branch.
- [ X] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ X] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on pull request #2436: SOLR-15161: Lets not encourage users to hack mime types on JSON responses.
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #2436:
URL: https://github.com/apache/lucene-solr/pull/2436#issuecomment-787144309
So by removing those, Solr will fall back to the implicit json response writer, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on pull request #2436: SOLR-15161: Lets not encourage users to hack mime types on JSON responses.
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2436:
URL: https://github.com/apache/lucene-solr/pull/2436#issuecomment-787189043
Yes, it is me of the implicit request handlers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh edited a comment on pull request #2436: SOLR-15161: Lets not encourage users to hack mime types on JSON responses.
Posted by GitBox <gi...@apache.org>.
epugh edited a comment on pull request #2436:
URL: https://github.com/apache/lucene-solr/pull/2436#issuecomment-787189043
Yes, it is one of the implicit request handlers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh closed pull request #2436: SOLR-15161: Lets not encourage users to hack mime types on JSON responses.
Posted by GitBox <gi...@apache.org>.
epugh closed pull request #2436:
URL: https://github.com/apache/lucene-solr/pull/2436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on pull request #2436: SOLR-15161: Lets not encourage users to hack mime types on JSON responses.
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2436:
URL: https://github.com/apache/lucene-solr/pull/2436#issuecomment-787090073
@ctargett the only place I can think this might have issues is in the tutorials, and I don't think it does there....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on pull request #2436: SOLR-15161: Lets not encourage users to hack mime types on JSON responses.
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2436:
URL: https://github.com/apache/lucene-solr/pull/2436#issuecomment-802386877
Migrated to https://github.com/apache/solr/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org