[GitHub] [httpcomponents-client] carterkozak commented on a change in pull request #235: HTTPCLIENT-2097: Fix PoolingAsyncClientConnectionManager boxed primitive reference equality

[GitBox <gi...@apache.org>]

carterkozak commented on a change in pull request #235:
URL: https://github.com/apache/httpcomponents-client/pull/235#discussion_r449903943



##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
##########
@@ -252,7 +252,7 @@ public void completed(final PoolEntry<HttpRoute, ManagedAsyncClientConnection> p
 
                                     @Override
                                     public void execute(final Boolean result) {
-                                        if (result == Boolean.FALSE) {
+                                        if (!result) {

Review comment:
       I had initially written it this way to retain identical semantics:
   
   ```suggestion
                                           if (result != null && !result) {
   ```
   
   But it's unclear what null would mean if it's possible, and further analysis indicated that nothing passed null values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org