You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Lai Wei <ro...@gmail.com> on 2019/07/10 09:33:34 UTC

[VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Dear community,

This is a call for a releasing Apache MXNet (incubating) 1.5.0, release
candidate 2.

Apache MXNet (incubating) community has voted and approved the release.

Vote thread:
https://lists.apache.org/thread.html/50fe473a3e03c891caccb8cae8e5195bb740a4758f7688790dff70df@%3Cdev.mxnet.apache.org%3E

Result thread:
https://lists.apache.org/thread.html/641cf0fddce623ff352ba9c7655938c0d16337bae4a8d290956ea130@%3Cdev.mxnet.apache.org%3E

The source tarball, including signatures, digests, etc. can be found at:
https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.5.0.rc2/

The tag to be voted upon is 1.5.0.rc2:
https://github.com/apache/incubator-mxnet/releases/tag/1.5.0.rc2

The release hash is 75a9e18:
https://github.com/apache/incubator-mxnet/commit/75a9e187d00a8b7ebc71412a02ed0e3ae489d91f

Release artifacts are signed with the following key, KEYS file available:
https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS

For information about the contents of this release, see:
https://cwiki.apache.org/confluence/display/MXNET/1.5.0+Release+Notes

The vote will be open for 72 hours.

[ ] +1 release this package as ...
[ ] +0 no opinion
[ ] -1 do not release this package because...


Best Regards

Lai

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Michael Wall <mj...@gmail.com>.
+1 binding

- Verified signatures
- license looks good
- build libmxnet.so successfully

On Sun, Jul 14, 2019 at 1:25 AM Sheng Zha <zh...@apache.org> wrote:

> Dear IPMC members,
>
> It would be great if you could help with the vote. Thank you.
>
> -sz
>
> On 2019/07/10 09:33:34, Lai Wei <ro...@gmail.com> wrote:
> > Dear community,
> >
> > This is a call for a releasing Apache MXNet (incubating) 1.5.0, release
> > candidate 2.
> >
> > Apache MXNet (incubating) community has voted and approved the release.
> >
> > Vote thread:
> >
> https://lists.apache.org/thread.html/50fe473a3e03c891caccb8cae8e5195bb740a4758f7688790dff70df@%3Cdev.mxnet.apache.org%3E
> >
> > Result thread:
> >
> https://lists.apache.org/thread.html/641cf0fddce623ff352ba9c7655938c0d16337bae4a8d290956ea130@%3Cdev.mxnet.apache.org%3E
> >
> > The source tarball, including signatures, digests, etc. can be found at:
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.5.0.rc2/
> >
> > The tag to be voted upon is 1.5.0.rc2:
> > https://github.com/apache/incubator-mxnet/releases/tag/1.5.0.rc2
> >
> > The release hash is 75a9e18:
> >
> https://github.com/apache/incubator-mxnet/commit/75a9e187d00a8b7ebc71412a02ed0e3ae489d91f
> >
> > Release artifacts are signed with the following key, KEYS file available:
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> >
> > For information about the contents of this release, see:
> > https://cwiki.apache.org/confluence/display/MXNET/1.5.0+Release+Notes
> >
> > The vote will be open for 72 hours.
> >
> > [ ] +1 release this package as ...
> > [ ] +0 no opinion
> > [ ] -1 do not release this package because...
> >
> >
> > Best Regards
> >
> > Lai
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Sheng Zha <zh...@apache.org>.
Dear IPMC members,

It would be great if you could help with the vote. Thank you.

-sz

On 2019/07/10 09:33:34, Lai Wei <ro...@gmail.com> wrote: 
> Dear community,
> 
> This is a call for a releasing Apache MXNet (incubating) 1.5.0, release
> candidate 2.
> 
> Apache MXNet (incubating) community has voted and approved the release.
> 
> Vote thread:
> https://lists.apache.org/thread.html/50fe473a3e03c891caccb8cae8e5195bb740a4758f7688790dff70df@%3Cdev.mxnet.apache.org%3E
> 
> Result thread:
> https://lists.apache.org/thread.html/641cf0fddce623ff352ba9c7655938c0d16337bae4a8d290956ea130@%3Cdev.mxnet.apache.org%3E
> 
> The source tarball, including signatures, digests, etc. can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.5.0.rc2/
> 
> The tag to be voted upon is 1.5.0.rc2:
> https://github.com/apache/incubator-mxnet/releases/tag/1.5.0.rc2
> 
> The release hash is 75a9e18:
> https://github.com/apache/incubator-mxnet/commit/75a9e187d00a8b7ebc71412a02ed0e3ae489d91f
> 
> Release artifacts are signed with the following key, KEYS file available:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> 
> For information about the contents of this release, see:
> https://cwiki.apache.org/confluence/display/MXNET/1.5.0+Release+Notes
> 
> The vote will be open for 72 hours.
> 
> [ ] +1 release this package as ...
> [ ] +0 no opinion
> [ ] -1 do not release this package because...
> 
> 
> Best Regards
> 
> Lai
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Lai Wei <ro...@gmail.com>.
Hi Justin,

Not yet, I have reached out to them.
Thanks!

Best Regards
Lai


On Wed, Jul 10, 2019 at 2:55 AM Justin Mclean <ju...@classsoftware.com>
wrote:

> Hi,
>
> Did you mentors or any other IPMC members vote on this release?
>
> Thanks,
> Justin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Did you mentors or any other IPMC members vote on this release?

Thanks,
Justin

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Lai Wei <ro...@gmail.com>.
Thank you very much for voting, I have sent out the result.[1]
I think it's best to remove or replace those images, I have summarized all
license issues on GitHub to track and resolve before next release.[2]

[1]
https://lists.apache.org/thread.html/89c17ab4a14f9004dc5ad96f07f28ac79f95f5fc9c593926c740feed@%3Cgeneral.incubator.apache.org%3E
[2] https://github.com/apache/incubator-mxnet/issues/15542


Best Regards

Lai


On Thu, Jul 18, 2019 at 8:15 PM Jason Dai <ja...@gmail.com> wrote:

> +1 (binding)
>
> I checked:
>  - incubating in name
>  - Signatures and checksum look good
>  - DISCLAIMER exists
>
> Thanks,
> -Jason
>
> On Fri, Jul 19, 2019 at 12:53 AM Sheng Zha <zh...@apache.org> wrote:
>
> > Dear IPMC members,
> >
> > Thank you for all the help in spotting the license issues. Given that
> they
> > are relatively minor we would like to address them in the next release.
> >
> > Since there is no longer any blocker, it would be great if you could
> > continue to vote on this release. We still need one more vote to make
> this
> > release. Thank you.
> >
> > Best,
> > -sz
> >
> > On 2019/07/17 21:50:01, Justin Mclean <ju...@classsoftware.com> wrote:
> > > Hi,
> > >
> > > > Duane Merril (author of CUB and this file in particular) sent an
> > explanation to this list, but either his reply is stuck in moderation or
> > there was some other technical difficulty and the message is not showing
> > up. Below is the email that he sent to me.
> > >
> > > Thanks for the explanation and that looks fine to me.
> > >
> > > Thanks,
> > > Justin
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Jason Dai <ja...@gmail.com>.
+1 (binding)

I checked:
 - incubating in name
 - Signatures and checksum look good
 - DISCLAIMER exists

Thanks,
-Jason

On Fri, Jul 19, 2019 at 12:53 AM Sheng Zha <zh...@apache.org> wrote:

> Dear IPMC members,
>
> Thank you for all the help in spotting the license issues. Given that they
> are relatively minor we would like to address them in the next release.
>
> Since there is no longer any blocker, it would be great if you could
> continue to vote on this release. We still need one more vote to make this
> release. Thank you.
>
> Best,
> -sz
>
> On 2019/07/17 21:50:01, Justin Mclean <ju...@classsoftware.com> wrote:
> > Hi,
> >
> > > Duane Merril (author of CUB and this file in particular) sent an
> explanation to this list, but either his reply is stuck in moderation or
> there was some other technical difficulty and the message is not showing
> up. Below is the email that he sent to me.
> >
> > Thanks for the explanation and that looks fine to me.
> >
> > Thanks,
> > Justin
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

+1 (binding) However note the image issues below, I'll leave it up to the project if they think it's OK to distribute these files or want to create a new release.

I checked:
- includbatibng in name
- signature and hashes correct
- NOTICE copyright don’t include current year ("2017 and onwards” should be "2017-2019")
- Several minor license issues in LICENSE (see previous emails)
- No unexpected binary files
- All ASF files have ASF headers
- Didn’t compile from source

There are a couple of images in the source distribution that are not mentioned in license:
1. ./contrib/clojure-package/examples/infer/objectdetector/images/marcel.jpg
2. ./contrib/clojure-package/test/test-images/Pug-Cookie.jpg
3. ./contrib/clojure-package/test/test-images/kitten.jpg
4. ./julia/examples/imagenet/ijulia-pretrained-predict/cat.png

Have the license of these images been confirmed and/or do you have permission from the owners to use/distribute them? If so it would be good to add those details to LICENSE. If not it may be best to replace those images with one of a known license compatible with ALv2 license.

From a quick search 1 looks to be a personal photo, 2 seems to be a stock photo, (but I cannot find its license), 3 has "Copyright by MaxPixel” as meta data (also unknown license), and 4 seem to be stock photos of unknown license.

Re 3, what I found about MaxPixel doesn’t sound good. [1] It seems they may of stole the image from here. [2]

Does the project want to distribute an image that may of been stolen from another site and copyright incorrectly claimed for it?

Thanks,
Justin

1. https://medium.com/the-daily-h/just-say-no-to-max-pixel-73ffea38eddb
2. https://pixabay.com/photos/cat-tabby-outdoors-animals-cute-1506960/
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Sheng Zha <zh...@apache.org>.
Dear IPMC members,

Thank you for all the help in spotting the license issues. Given that they are relatively minor we would like to address them in the next release.

Since there is no longer any blocker, it would be great if you could continue to vote on this release. We still need one more vote to make this release. Thank you.

Best,
-sz

On 2019/07/17 21:50:01, Justin Mclean <ju...@classsoftware.com> wrote: 
> Hi,
> 
> > Duane Merril (author of CUB and this file in particular) sent an explanation to this list, but either his reply is stuck in moderation or there was some other technical difficulty and the message is not showing up. Below is the email that he sent to me.
> 
> Thanks for the explanation and that looks fine to me.
> 
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> Duane Merril (author of CUB and this file in particular) sent an explanation to this list, but either his reply is stuck in moderation or there was some other technical difficulty and the message is not showing up. Below is the email that he sent to me.

Thanks for the explanation and that looks fine to me.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Przemys��aw Tr��dak <pt...@apache.org>.
Duane Merril (author of CUB and this file in particular) sent an explanation to this list, but either his reply is stuck in moderation or there was some other technical difficulty and the message is not showing up. Below is the email that he sent to me:



From: Duane Merrill
Sent: Wednesday, July 17, 2019 12:58 PM
To: Przemek Tredak
Cc: Duane Merrill
Subject: FW: Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2
 
Hi Przemek, I don’t seem to be able to OAUTH to Ponymail via Google, and my attempts to use the mailto: link seem to have sent my response below into a black hole.  Feel free to forward, if you like.

 

Duane

 

From: Duane Merrill 
Sent: Wednesday, July 17, 2019 3:29 PM
To: general@incubator.apache.org
Cc: Duane Merrill <du...@nvidia.com>
Subject: Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

 

Hi,

I’m the author of CUB, and in particular, [9] (half.h) below.

>> but what about the last one [9]?

The boilerplate no-redistribution license at top of half.h was an oversight; it should read the same as the BSD-style headers for the rest of CUB’s source files.  (It was cribbed from an internal project to facilitate regression testing, and isn’t part of the core library.  I simply forgot to update the header when adding regression tests for that data type type.) 

I’ve updated the source for half.h in CUB’s master branch (see https://github.com/NVlabs/cub/blob/master/test/half.h).  However, it would be several days before I could qualify and tag a new release version (v1.8.1) of CUB.  Further, there are several other aspects of “master” that are ahead of the current v1.8.0 branch, which might impact your own release qualification process.  Let me know if snapping a new release would be a priority for you.

Happy to help,

Duane

_____________________

Duane Merrill, PhD

Principal Research Scientist

NVIDIA Corporation

dumerrill@nvidia.com


On 2019/07/17 05:08:08, Justin Mclean <ju...@classsoftware.com> wrote: 
> Hi,
> 
> > It’s added in this PR[1] which is trying to improve our LICENSE file. 
> 
> Thanks for that.
> 
> > I have verified all license in the top level LICENSE file are included in
> > source release except this MKL BLAS license.
> 
> I run the release through Fossology [1] and did some spot checks (not an exhaustive check) and it found a number of things:
> - [2] Seems to be BSD 3 clause not BSD 2 clause
> - LICENSE seems to be missing info on [3][4][5][6][7][8] (all are permissive licenses). There might be other things missing.
> - This file [9] may be an issue as it contains "Redistribution and use in source and binary forms, with or without modification, are not permitted.”
> 
> There was not other category X license or included files that I could see. Obviously the first 2 are fix next release sort of issues, but what about the last one [9]?
> 
> Thanks,
> Justin
> 
> 1. https://www.fossology.org
> 2. /3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tools/FindPythonLibsNew.cmake
> 3. /src/operator/contrib/erfinv-inl.h
> 4. /3rdparty/nvidia_cub/test/mersenne.h
> 5. /3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tools/FindEigen3.cmake
> 6. /3rdparty/onnx-tensorrt/third_party/onnx/tools/protoc-gen-mypy.py
> 7. /src/operator/special_functions-inl.h
> 8. /3rdparty/tvm/3rdparty/rang/LICENSE
> 9 ./3rdparty/nvidia_cub/test/half.h
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> It’s added in this PR[1] which is trying to improve our LICENSE file. 

Thanks for that.

> I have verified all license in the top level LICENSE file are included in
> source release except this MKL BLAS license.

I run the release through Fossology [1] and did some spot checks (not an exhaustive check) and it found a number of things:
- [2] Seems to be BSD 3 clause not BSD 2 clause
- LICENSE seems to be missing info on [3][4][5][6][7][8] (all are permissive licenses). There might be other things missing.
- This file [9] may be an issue as it contains "Redistribution and use in source and binary forms, with or without modification, are not permitted.”

There was not other category X license or included files that I could see. Obviously the first 2 are fix next release sort of issues, but what about the last one [9]?

Thanks,
Justin

1. https://www.fossology.org
2. /3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tools/FindPythonLibsNew.cmake
3. /src/operator/contrib/erfinv-inl.h
4. /3rdparty/nvidia_cub/test/mersenne.h
5. /3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tools/FindEigen3.cmake
6. /3rdparty/onnx-tensorrt/third_party/onnx/tools/protoc-gen-mypy.py
7. /src/operator/special_functions-inl.h
8. /3rdparty/tvm/3rdparty/rang/LICENSE
9 ./3rdparty/nvidia_cub/test/half.h
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Lai Wei <ro...@gmail.com>.
Hi Justin,

It’s added in this PR[1] which is trying to improve our LICENSE file. A
bunch of submodules were also added and we are aware we should only include
those bundled in source release.
I have verified all license in the top level LICENSE file are included in
source release except this MKL BLAS license. It was added by mistake since
there was some confusion on MKL-DNN (Apache 2.0), MKLML(Intel simplified
license) and MKL (intel simplified license).

There are two related options in MXNet build flags, USE_BLAS and
USE_MKLDNN, USE_BLAS has option to use full MKL BLAS, users has to install
separately and it's not included in MXNet release. USE_MKLDNN=1 will use
MKLDNN(included in MXNet source release).  MKLDNN will donwload MKLML with
intel simplified license during build time only. As per discussion here,
the Intel simplified license  should be removed from LICENSE file.[2]

[1]
https://github.com/apache/incubator-mxnet/pull/13808/files#diff-9879d6db96fd29134fc802214163b95aR535
[2]https://github.com/apache/incubator-mxnet/blob/master/make/config.mk#L111


On Tue, Jul 16, 2019 at 2:45 AM Justin Mclean <ju...@classsoftware.com>
wrote:

> Hi,
>
> > For [1], I think we need to remove it. For [2] I have raised on legal
> via JIRA[3].
>
> Thanks. It would be nice to know why this happened, and depending on that
> answer there may be more work to do to get the LICENSE into shape. I’m
> guessing that teh project may of added all dependancies to the LICENSE file
> when you only need to add what is bundled in the source release.
>
> > Can we resolve these issues during the next release?
>
> Sure but’s that’s not up to me.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> For [1], I think we need to remove it. For [2] I have raised on legal via JIRA[3].

Thanks. It would be nice to know why this happened, and depending on that answer there may be more work to do to get the LICENSE into shape. I’m guessing that teh project may of added all dependancies to the LICENSE file when you only need to add what is bundled in the source release.

> Can we resolve these issues during the next release?

Sure but’s that’s not up to me.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Lai Wei <ro...@gmail.com>.
Hi Justin,

I have created 2 issues for MKL[1] and pybind[2].

For [1], I think we need to remove it. For [2] I have raised on legal via
JIRA[3].
Can we resolve these issues during the next release?

Thanks!


[1] https://github.com/apache/incubator-mxnet/issues/15544
[2] https://github.com/apache/incubator-mxnet/issues/15547
[3] https://issues.apache.org/jira/browse/LEGAL-468

Best Regards

Lai


On Mon, Jul 15, 2019 at 3:52 PM Justin Mclean <ju...@classsoftware.com>
wrote:

> Hi,
>
> > These licenses are for using MKL (the full release) as BLAS library.
> This functionality is optional and is not enabled by default. MKL is not
> shipped in source code.
>
> If none of the code is bundled in the release artefact why is it mentioned
> in LICENSE? [1]
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> These licenses are for using MKL (the full release) as BLAS library. This functionality is optional and is not enabled by default. MKL is not shipped in source code.

If none of the code is bundled in the release artefact why is it mentioned in LICENSE? [1]

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#guiding-principle
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Sheng Zha <zh...@apache.org>.
These licenses are for using MKL (the full release) as BLAS library. This functionality is optional and is not enabled by default. MKL is not shipped in source code.

-sz

On 2019/07/15 22:39:14, Justin Mclean <ju...@classsoftware.com> wrote: 
> Hi,
> 
> I was just taking at look at the release and noticed the LICENSE file includes the "Intel® Simplified license” this includes this clause "No reverse engineering, decompilation, or disassembly of this Software is permitted.” and there's also a "Limited patent license” mentioned which may be of concern. This license is listed as a Category X license [1] so is not allowed in a source release or as a dependancy  (unless it’s optional).
> 
> This license [2] may also need clarification on legal-discuss, if that hasn’t been done so.
> 
> Thanks,
> Justin
> 
> 1. https://www.apache.org/legal/resolved.html#category-x
> 2. 3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/LICENSE
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

I was just taking at look at the release and noticed the LICENSE file includes the "Intel® Simplified license” this includes this clause "No reverse engineering, decompilation, or disassembly of this Software is permitted.” and there's also a "Limited patent license” mentioned which may be of concern. This license is listed as a Category X license [1] so is not allowed in a source release or as a dependancy  (unless it’s optional).

This license [2] may also need clarification on legal-discuss, if that hasn’t been done so.

Thanks,
Justin

1. https://www.apache.org/legal/resolved.html#category-x
2. 3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/LICENSE
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Lai Wei <ro...@gmail.com>.
Hi,

Thanks for helping validate and vote the release. I have created follow up
issue in MXNet[1] to be resolved before next release.
I think we should add note and the original license, aslo tagged the
contributor for more history.

It would be great if other IPMC members could help with the vote, really
appreciate it!
Thanks!

[1] https://github.com/apache/incubator-mxnet/issues/15542

Best Regards

Lai


On Mon, Jul 15, 2019 at 8:39 AM Paul King <pa...@asert.com.au> wrote:

> +1 binding
>
> checked signature/checksum/disclaimer
> license seems very thorough but two possible clarifications are suggested
> below (*)
> ran `make lib/libmxnet.so` successfully (opencv was listed as an optional
> dependency but it seemed to be needed for this to work)
> ran `make scalapkg` to generate Scala/Java jars (seemed to need to set
> LD_LIBRARY_PATH for this to work)
> ran `make ratcheck`
> ran some Groovy/MXNet examples with the new jars - all worked
>
> Cheers, Paul.
> ----
>
> (*) I can't be sure without understanding the history but it seems like
> there is possibly scope
> to improve clarity for these two files for future releases:
>
> 10. ONNX Export module (python/mxnet/contrib/onnx/mx2onnx/LICENSE)
> 14. cmake/Modules/FindJeMalloc.cmake
>
> It looks like both are based on some original but have been modified but
> there are just two
> different copyright notices with Apache License just pasted above the
> previous one.
> Hard to tell just from that what the history is. It might be clearer with
> some additional wording, e.g.
>
> ----------.8-----------
> Originally based on code with the following license:
>
>       Original license text
>
> And has been modified by the Apache MXNet project. Modifications have the
> following license:
>
>     Apache License text
> ----------.8-----------
>
> But maybe there is further history behind those files, so hard to tell for
> sure.
>
>
>
> On Wed, Jul 10, 2019 at 7:34 PM Lai Wei <ro...@gmail.com> wrote:
>
> > Dear community,
> >
> > This is a call for a releasing Apache MXNet (incubating) 1.5.0, release
> > candidate 2.
> >
> > Apache MXNet (incubating) community has voted and approved the release.
> >
> > Vote thread:
> >
> >
> https://lists.apache.org/thread.html/50fe473a3e03c891caccb8cae8e5195bb740a4758f7688790dff70df@%3Cdev.mxnet.apache.org%3E
> >
> > Result thread:
> >
> >
> https://lists.apache.org/thread.html/641cf0fddce623ff352ba9c7655938c0d16337bae4a8d290956ea130@%3Cdev.mxnet.apache.org%3E
> >
> > The source tarball, including signatures, digests, etc. can be found at:
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.5.0.rc2/
> >
> > The tag to be voted upon is 1.5.0.rc2:
> > https://github.com/apache/incubator-mxnet/releases/tag/1.5.0.rc2
> >
> > The release hash is 75a9e18:
> >
> >
> https://github.com/apache/incubator-mxnet/commit/75a9e187d00a8b7ebc71412a02ed0e3ae489d91f
> >
> > Release artifacts are signed with the following key, KEYS file available:
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
> >
> > For information about the contents of this release, see:
> > https://cwiki.apache.org/confluence/display/MXNET/1.5.0+Release+Notes
> >
> > The vote will be open for 72 hours.
> >
> > [ ] +1 release this package as ...
> > [ ] +0 no opinion
> > [ ] -1 do not release this package because...
> >
> >
> > Best Regards
> >
> > Lai
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc2

Posted by Paul King <pa...@asert.com.au>.
+1 binding

checked signature/checksum/disclaimer
license seems very thorough but two possible clarifications are suggested
below (*)
ran `make lib/libmxnet.so` successfully (opencv was listed as an optional
dependency but it seemed to be needed for this to work)
ran `make scalapkg` to generate Scala/Java jars (seemed to need to set
LD_LIBRARY_PATH for this to work)
ran `make ratcheck`
ran some Groovy/MXNet examples with the new jars - all worked

Cheers, Paul.
----

(*) I can't be sure without understanding the history but it seems like
there is possibly scope
to improve clarity for these two files for future releases:

10. ONNX Export module (python/mxnet/contrib/onnx/mx2onnx/LICENSE)
14. cmake/Modules/FindJeMalloc.cmake

It looks like both are based on some original but have been modified but
there are just two
different copyright notices with Apache License just pasted above the
previous one.
Hard to tell just from that what the history is. It might be clearer with
some additional wording, e.g.

----------.8-----------
Originally based on code with the following license:

      Original license text

And has been modified by the Apache MXNet project. Modifications have the
following license:

    Apache License text
----------.8-----------

But maybe there is further history behind those files, so hard to tell for
sure.



On Wed, Jul 10, 2019 at 7:34 PM Lai Wei <ro...@gmail.com> wrote:

> Dear community,
>
> This is a call for a releasing Apache MXNet (incubating) 1.5.0, release
> candidate 2.
>
> Apache MXNet (incubating) community has voted and approved the release.
>
> Vote thread:
>
> https://lists.apache.org/thread.html/50fe473a3e03c891caccb8cae8e5195bb740a4758f7688790dff70df@%3Cdev.mxnet.apache.org%3E
>
> Result thread:
>
> https://lists.apache.org/thread.html/641cf0fddce623ff352ba9c7655938c0d16337bae4a8d290956ea130@%3Cdev.mxnet.apache.org%3E
>
> The source tarball, including signatures, digests, etc. can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.5.0.rc2/
>
> The tag to be voted upon is 1.5.0.rc2:
> https://github.com/apache/incubator-mxnet/releases/tag/1.5.0.rc2
>
> The release hash is 75a9e18:
>
> https://github.com/apache/incubator-mxnet/commit/75a9e187d00a8b7ebc71412a02ed0e3ae489d91f
>
> Release artifacts are signed with the following key, KEYS file available:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/KEYS
>
> For information about the contents of this release, see:
> https://cwiki.apache.org/confluence/display/MXNET/1.5.0+Release+Notes
>
> The vote will be open for 72 hours.
>
> [ ] +1 release this package as ...
> [ ] +0 no opinion
> [ ] -1 do not release this package because...
>
>
> Best Regards
>
> Lai
>