You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/08 06:40:04 UTC
[GitHub] [beam] fernando-wizeline opened a new pull request, #23080: GA Migration RAT Spotless Whitespace PreCommit
fernando-wizeline opened a new pull request, #23080:
URL: https://github.com/apache/beam/pull/23080
Adding github actions yaml files.
Updating README and removing jenkins groovy files
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1265685531
> Just had one question. Could you please file an issue for the more nicely formatted report as well?
Sure thing, Danny! I will let you know once the issue is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1245665924
# [Codecov](https://codecov.io/gh/apache/beam/pull/23080?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23080](https://codecov.io/gh/apache/beam/pull/23080?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d74377) into [master](https://codecov.io/gh/apache/beam/commit/c7f64264451af12ff6c7c0ef4bc95fd7ce0f5418?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c7f6426) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #23080 +/- ##
==========================================
- Coverage 73.98% 73.93% -0.06%
==========================================
Files 713 716 +3
Lines 94048 94314 +266
==========================================
+ Hits 69582 69729 +147
- Misses 23180 23299 +119
Partials 1286 1286
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.40% <ø> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/23080?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/typehints/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL19faW5pdF9fLnB5) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/statecache.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc3RhdGVjYWNoZS5weQ==) | `89.69% <0.00%> (-6.47%)` | :arrow_down: |
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...dks/python/apache\_beam/metrics/monitoring\_infos.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tb25pdG9yaW5nX2luZm9zLnB5) | `92.50% <0.00%> (-4.50%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/pickler.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvcGlja2xlci5weQ==) | `92.00% <0.00%> (-3.46%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `76.66% <0.00%> (-3.05%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.06% <0.00%> (-1.33%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/schemas.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3NjaGVtYXMucHk=) | `96.62% <0.00%> (-1.05%)` | :arrow_down: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `92.44% <0.00%> (-0.65%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.05% <0.00%> (-0.39%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/beam/pull/23080/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1640362749
Closing as stale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23080:
URL: https://github.com/apache/beam/pull/23080#discussion_r984991003
##########
sdks/python/test-suites/tox/py38/build.gradle:
##########
@@ -112,6 +112,8 @@ task archiveFilesToLint(type: Zip) {
include "**/*.md"
include "**/build.gradle"
exclude "**/node_modules/*"
+ exclude ".github/*"
+ exclude "website/*"
Review Comment:
Did you mean to include this? Why do we need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1248339193
> Currently the errors are presented in the results window of the github job right at the end, with all the info as to why they failed the validation.
That sounds fine to me - depending on how good they are we might not need to come back to report generation at all. Any chance you could share a screenshot of an example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1248472411
> Thanks for sharing - lets definitely skip this for now. Since its a little tough to read that output, I'd like to at least explore options for a nicer report eventually, but it definitely should not block us moving this over to GHA.
Great! Sounds like a plan. We'll move forward with this and explore alternatives for later implementation.
Thanks again Danny!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1248168470
> My question is: would it be ok if we skip the report generation for the time being? Please let me know what you think about this.
What does the current experience look like when there is a violation? I'm fine not generating the report as long as there's a good way to figure out what violation caused a workflow to fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1417735623
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1248426283
Thanks for sharing - lets definitely skip this for now. Since its a little tough to read that output, I'd like to at least explore options for a nicer report eventually, but it definitely should not block us moving this over to GHA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1582512595
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1262535137
Run Spotless PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1247378238
Hi @damccorm!
We're facing a minor inconvenience regarding the checkstyle report created by the spotless task. In jenkins, that task creates a report like the [following](https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/22573/checkstyle/)
There are a couple of unofficial plugins that generate a really short status section within github, although not that different from the one already provided by github.
My question is: would it be ok if we skip the report generation for the time being? Please let me know what you think about this.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1265723273
> In jenkins, that task creates a report like the [following](https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/22573/checkstyle/)
> There are a couple of unofficial plugins that generate a really short status section within github, although not that different from the one already provided by github.
Issue filed here: https://github.com/apache/beam/issues/23466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23080:
URL: https://github.com/apache/beam/pull/23080#discussion_r985974851
##########
sdks/python/test-suites/tox/py38/build.gradle:
##########
@@ -112,6 +112,8 @@ task archiveFilesToLint(type: Zip) {
include "**/*.md"
include "**/build.gradle"
exclude "**/node_modules/*"
+ exclude ".github/*"
+ exclude "website/*"
Review Comment:
Yeah, they're being picked up by the py38 process (not sure why) so I had to manually exclude them from the paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1336403312
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1248244217
> > My question is: would it be ok if we skip the report generation for the time being? Please let me know what you think about this.
>
> What does the current experience look like when there is a violation? I'm fine not generating the report as long as there's a good way to figure out what violation caused a workflow to fail
Hi Danny!
Currently the errors are presented in the results window of the github job right at the end, with all the info as to why they failed the validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23080:
URL: https://github.com/apache/beam/pull/23080#issuecomment-1248343822
> > Currently the errors are presented in the results window of the github job right at the end, with all the info as to why they failed the validation.
>
> That sounds fine to me - depending on how good they are we might not need to come back to report generation at all. Any chance you could share a screenshot of an example?
Totally!
This is the screenshot:
<img width="1382" alt="Screen Shot 2022-09-15 at 10 32 17" src="https://user-images.githubusercontent.com/80284146/190458549-c4172c95-58a4-4cb1-90cb-9eab811fc7bb.png">
and the link to the results windows is this: https://github.com/fernando-wizeline/beam/actions/runs/3061434614/jobs/4941196972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23080: GA Migration RAT Spotless Whitespace PreCommit
URL: https://github.com/apache/beam/pull/23080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org