You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/03/03 04:05:57 UTC

[GitHub] [thrift] ctubbsii commented on pull request #2525: THRIFT-5521: [java gen] use jdk8 option type in java generator code

ctubbsii commented on pull request #2525:
URL: https://github.com/apache/thrift/pull/2525#issuecomment-1057644177


   > > but would probably prefer it be on by default.
   > 
   > @ctubbsii do you suggest that i [flip the default](https://github.com/apache/thrift/pull/2525/files#diff-c59dffe78e4250a1f0450c496300e137aa1631b60488108e237a292a1c2e6789R105) here in this PR?
   
   I meant backwards-compatibility, in the sense that the generated code wouldn't have a different API, which could cause problems for user code that interfaced with the generated code.
   
   I would wait for consensus before flipping. I am just one voice, and others may prefer to keep the original behavior they've become accustomed to. I have the luxury of not caring about the previous behavior, because I've never used optional fields in my IDL files before. I expect that my preference is in the minority.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org