You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/06 06:24:12 UTC

[GitHub] [apisix] tokers opened a new pull request #4186: fix: init dns resolvers in stream subsystem.

tokers opened a new pull request #4186:
URL: https://github.com/apache/apisix/pull/4186


   Since f914807, the connect of tcpsock was patched by using our own DNS
   resolvers. It relies on a dns_resolvers variable which should be
   initialized in init_by_lua* phase, however, the initialization step in
   stream sub-system is missed so once users enable the stream proxy and
   the tcpsock:connect is invoked with a non-IP host, Lua runtime errors
   will be thrown.
   
   This PR fixed this issue by initializing the DNS resolvers in the stream
   sub-subsystem.
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #4186: fix: init dns resolvers in stream subsystem

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4186:
URL: https://github.com/apache/apisix/pull/4186


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org