[jira] [Commented] (PHOENIX-6587) Validate explicit pre-split and existing splits on salted tables

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468398#comment-17468398 ] 

ASF GitHub Bot commented on PHOENIX-6587:
-----------------------------------------

stoty commented on pull request #1353:
URL: https://github.com/apache/phoenix/pull/1353#issuecomment-1004578856


   Some more reasoning to remove SchemaUtil.processSplit() :
   
   AFAICT it tries to emulate how HBase would automatically split a region.
   However, I could not find any reason why we would want to do that.
   * It is not necessary for correctness
   * It always adds an extra region to scan, as a salt key will always extend to an extra region (but this extra region is  guaranteed to not have any rows)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Validate explicit pre-split and existing splits on salted tables
> ----------------------------------------------------------------
>
>                 Key: PHOENIX-6587
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6587
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Minor
>
> Specifying the split points manually on salted tables can break them.
> The easiest thing to do is to disallow it, which ensures that the table is created with the default per bucket presplit.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)