[GitHub] [incubator-nemo] johnyangk commented on a change in pull request #281: [NEMO-437] Support Java version 11

[GitBox <gi...@apache.org>]

johnyangk commented on a change in pull request #281: [NEMO-437] Support Java version 11
URL: https://github.com/apache/incubator-nemo/pull/281#discussion_r373954281
 
 

 ##########
 File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/PipelineTranslator.java
 ##########
 @@ -443,6 +442,12 @@ private static AbstractDoFnTransform createDoFnTransform(final PipelineTranslati
         Iterables.getOnlyElement(TransformInputs.nonAdditionalInputs(pTransform));
 
       final HasDisplayData displayData = (builder) -> builder.add(DisplayData.item("name", beamNode.getFullName()));
+      final DoFnSchemaInformation doFnSchemaInformation;
+      if (ctx.getCurrentTransform() != null) {
+        doFnSchemaInformation = ParDoTranslation.getSchemaInformation(ctx.getCurrentTransform());
+      } else {
+        doFnSchemaInformation = DoFnSchemaInformation.create();
 
 Review comment:
   It's not straightforward to me why it creates a new schema information when the current transform is null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services