You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2023/01/03 11:04:45 UTC

[GitHub] [inlong] fuweng11 opened a new pull request, #7136: [INLONG-7135][Manager] Support the connection test of data nodes and clusters

fuweng11 opened a new pull request, #7136:
URL: https://github.com/apache/inlong/pull/7136

   
   ### Prepare a Pull Request
   - Fixes #7135 
   
   ### Motivation
   
   Support the connection test of data nodes and clusters
   ### Modifications
   
   Support the connection test of data nodes and clusters
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] vernedeng commented on a diff in pull request #7136: [INLONG-7135][Manager] Support the connection test of data nodes and clusters

Posted by GitBox <gi...@apache.org>.
vernedeng commented on code in PR #7136:
URL: https://github.com/apache/inlong/pull/7136#discussion_r1060487146


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/PulsarClusterOperator.java:
##########
@@ -86,4 +88,20 @@ protected void setTargetEntity(ClusterRequest request, InlongClusterEntity targe
         }
     }
 
+    @Override
+    public Boolean testConnection(ClusterRequest request) {
+        PulsarClusterRequest pulsarRequest = (PulsarClusterRequest) request;
+        PulsarClusterInfo pulsarInfo = new PulsarClusterInfo();
+        CommonBeanUtils.copyProperties(pulsarRequest, pulsarInfo);
+        try (PulsarAdmin ignored = PulsarUtils.getPulsarAdmin(pulsarInfo)) {
+            LOGGER.info("pulsar connection not null - connection success");

Review Comment:
   Suggest log out the information of test pulsar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] gong merged pull request #7136: [INLONG-7135][Manager] Support the connection test of data nodes and clusters

Posted by GitBox <gi...@apache.org>.
gong merged PR #7136:
URL: https://github.com/apache/inlong/pull/7136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org