You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rafael Weingärtner <ra...@gmail.com> on 2015/08/29 03:50:54 UTC

Review wanted for PR 714 (CLOUDSTACK-8750)

Hi folks,
This email is meant to ping the community about the PR (714) that solves
the ticket CLOUDSTACK-8750 (
https://issues.apache.org/jira/browse/CLOUDSTACK-8750).

The commit at first sight might look a bit too big to review, but at the
end it is a pretty easy. It will remove a few lines of code while removing
some issues on Sonar code analysis.
If I am not mistaken @DaanHoogland has already given a LGTM in a past mail
about this PR.



-- 
Rafael Weingärtner

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Mike Tutkowski <mi...@solidfire.com>.
At several of the companies where I've worked before, we would hold "bug
court" a couple times per week as the release marched on.

Representatives from different areas (product marketing, sales, support,
engineering, etc.) would attend and we'd go through all issues opened since
the previous bug court and prioritize them. Depending on how close we were
to GA for a release, less critical defects (unless trivial to fix) would be
postponed until a subsequent release.

This allowed us to control more closely what went into a release the closer
we got to GA, but it's probably not practical for CloudStack as it requires
a fair amount of discussion for each new issue.

On Tue, Sep 1, 2015 at 2:11 AM, Daan Hoogland <da...@gmail.com>
wrote:

> There is something like this on the page by Remi on the new release
> procedure. It is one of the lesser things about it. I think we should only
> look at stability. The discussion on what is minor or major is not
> something we want to need to have.
>
> On Tue, Sep 1, 2015 at 3:48 AM, Mike Tutkowski <
> mike.tutkowski@solidfire.com
> > wrote:
>
> > What do we think, though, about tickets listed as Minor going in at this
> > point in 4.6 development?
> >
> > If they entail a trivial change in only a file or two, it's probably OK,
> > but where should we draw the line?
> >
> > At some point as the release goes on, we should stop accepting PRs that
> are
> > tied to Minor tickets and only allow churn in that branch for more major
> > issues. Those PRs tied to Minor tickets can then be for the next release.
> >
> > Thoughts?
> >
> > On Mon, Aug 31, 2015 at 12:03 PM, Daan Hoogland <daan.hoogland@gmail.com
> >
> > wrote:
> >
> > > As David says; Though I think it is very polite of you to wait and ask
> > > around, you have this right if you can show master doesn't work.
> > >
> > > On Mon, Aug 31, 2015 at 6:06 PM, David Nalley <da...@gnsa.us> wrote:
> > >
> > > > On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das <
> koushik.das@citrix.com>
> > > > wrote:
> > > > > I am no longer able to start MS after this. I did a clean build
> > > followed
> > > > by starting MS. Did travis pass for it? Should we revert?
> > > > >
> > > >
> > > > Yes, and in general, when things break you should feel empowered to
> > > > revert (still send a note to the list, but as a committer, you have a
> > > > binding veto at your disposal - feel free to make use of it to keep
> > > > quality high.)
> > > >
> > > > --David
> > > >
> > >
> > >
> > >
> > > --
> > > Daan
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkowski@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > <http://solidfire.com/solution/overview/?video=play>*™*
> >
>
>
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Daan Hoogland <da...@gmail.com>.
There is something like this on the page by Remi on the new release
procedure. It is one of the lesser things about it. I think we should only
look at stability. The discussion on what is minor or major is not
something we want to need to have.

On Tue, Sep 1, 2015 at 3:48 AM, Mike Tutkowski <mike.tutkowski@solidfire.com
> wrote:

> What do we think, though, about tickets listed as Minor going in at this
> point in 4.6 development?
>
> If they entail a trivial change in only a file or two, it's probably OK,
> but where should we draw the line?
>
> At some point as the release goes on, we should stop accepting PRs that are
> tied to Minor tickets and only allow churn in that branch for more major
> issues. Those PRs tied to Minor tickets can then be for the next release.
>
> Thoughts?
>
> On Mon, Aug 31, 2015 at 12:03 PM, Daan Hoogland <da...@gmail.com>
> wrote:
>
> > As David says; Though I think it is very polite of you to wait and ask
> > around, you have this right if you can show master doesn't work.
> >
> > On Mon, Aug 31, 2015 at 6:06 PM, David Nalley <da...@gnsa.us> wrote:
> >
> > > On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das <ko...@citrix.com>
> > > wrote:
> > > > I am no longer able to start MS after this. I did a clean build
> > followed
> > > by starting MS. Did travis pass for it? Should we revert?
> > > >
> > >
> > > Yes, and in general, when things break you should feel empowered to
> > > revert (still send a note to the list, but as a committer, you have a
> > > binding veto at your disposal - feel free to make use of it to keep
> > > quality high.)
> > >
> > > --David
> > >
> >
> >
> >
> > --
> > Daan
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*™*
>



-- 
Daan

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Mike Tutkowski <mi...@solidfire.com>.
What do we think, though, about tickets listed as Minor going in at this
point in 4.6 development?

If they entail a trivial change in only a file or two, it's probably OK,
but where should we draw the line?

At some point as the release goes on, we should stop accepting PRs that are
tied to Minor tickets and only allow churn in that branch for more major
issues. Those PRs tied to Minor tickets can then be for the next release.

Thoughts?

On Mon, Aug 31, 2015 at 12:03 PM, Daan Hoogland <da...@gmail.com>
wrote:

> As David says; Though I think it is very polite of you to wait and ask
> around, you have this right if you can show master doesn't work.
>
> On Mon, Aug 31, 2015 at 6:06 PM, David Nalley <da...@gnsa.us> wrote:
>
> > On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das <ko...@citrix.com>
> > wrote:
> > > I am no longer able to start MS after this. I did a clean build
> followed
> > by starting MS. Did travis pass for it? Should we revert?
> > >
> >
> > Yes, and in general, when things break you should feel empowered to
> > revert (still send a note to the list, but as a committer, you have a
> > binding veto at your disposal - feel free to make use of it to keep
> > quality high.)
> >
> > --David
> >
>
>
>
> --
> Daan
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Daan Hoogland <da...@gmail.com>.
As David says; Though I think it is very polite of you to wait and ask
around, you have this right if you can show master doesn't work.

On Mon, Aug 31, 2015 at 6:06 PM, David Nalley <da...@gnsa.us> wrote:

> On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das <ko...@citrix.com>
> wrote:
> > I am no longer able to start MS after this. I did a clean build followed
> by starting MS. Did travis pass for it? Should we revert?
> >
>
> Yes, and in general, when things break you should feel empowered to
> revert (still send a note to the list, but as a committer, you have a
> binding veto at your disposal - feel free to make use of it to keep
> quality high.)
>
> --David
>



-- 
Daan

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by David Nalley <da...@gnsa.us>.
On Mon, Aug 31, 2015 at 12:57 AM, Koushik Das <ko...@citrix.com> wrote:
> I am no longer able to start MS after this. I did a clean build followed by starting MS. Did travis pass for it? Should we revert?
>

Yes, and in general, when things break you should feel empowered to
revert (still send a note to the list, but as a committer, you have a
binding veto at your disposal - feel free to make use of it to keep
quality high.)

--David

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Rafael Weingärtner <ra...@gmail.com>.
Hi folks, sorry the trouble with that PR.
I am taking a look into that right now.

The bean “HAProxyLBRule” is created on cloud-server, then it is inject into
“VirtualRouterElement” .

I am wondering, plugins in general do not have access to beans created in
cloud-server spring-context?

I noticed that the project “cloud-plugin-network-internallb” does not have
the “module.properties” file that is used to build the
spring-application-context hierarchy; shouldn’t it have a module.properties
with that configuration?

Something like this:
name= cloud-plugin-network-internallb
parent=core

On Mon, Aug 31, 2015 at 2:46 AM, Rajani Karuturi <ra...@apache.org> wrote:

> I am doing a build with revert locally. Will revert once done.
>
> ~Rajani
>
> On Mon, Aug 31, 2015 at 11:11 AM, Remi Bergsma <
> RBergsma@schubergphilis.com>
> wrote:
>
> > I say we revert so the 4.6 testing can continue and then work on fixing
> > why this broke the build. No hard feelings, we simply need master to
> build.
> >
> > If someone can revert, please do. I can do it in about two hours.
> >
> > Sent from my iPhone
> >
> > > On 31 Aug 2015, at 06:58, Koushik Das <ko...@citrix.com> wrote:
> > >
> > > I am no longer able to start MS after this. I did a clean build
> followed
> > by starting MS. Did travis pass for it? Should we revert?
> > >
> > >> mvn clean install -Dsimulator -DskipTests
> > >> mvn -pl client jetty:run -Dsimulator
> > >
> > > Getting the following error. No qualifying bean of type
> > [com.cloud.network.element.HAProxyLBRule] found for dependency: expected
> at
> > least 1 bean which qualifies as autowire candidate for this dependency.
> > >
> > > 2015-08-31 09:51:29.195:WARN::Nested in
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'accountManagerImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: private com.cloud.storage.dao.VMTemplateDao
> > com.cloud.user.AccountManagerImpl._templateDao; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'VMTemplateDaoImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao
> > com.cloud.storage.dao.VMTemplateDaoImpl._templateDataStoreDao; nested
> > exception is org.springframework.beans.factory.BeanCreationException:
> Error
> > creating bean with name 'templateDataStoreDaoImpl': Injection of
> autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: private
> > org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager
> >
> org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl._storeMgr;
> > nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'dataStoreProviderManager': Injection of autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field:
> > org.apache.cloudstack.storage.datastore.PrimaryDataStoreProviderManager
> >
> org.apache.cloudstack.storage.datastore.provider.DataStoreProviderManagerImpl.primaryDataStoreProviderMgr;
> > nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'primaryDataStoreProviderMgr': Injection of autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.storage.StorageManager
> >
> org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.storageMgr;
> > nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'storageManagerImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: protected com.cloud.agent.AgentManager
> > com.cloud.storage.StorageManagerImpl._agentMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'clusteredAgentManagerImpl': Injection of autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: protected com.cloud.ha.HighAvailabilityManager
> > com.cloud.agent.manager.AgentManagerImpl._haMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'highAvailabilityManagerExtImpl': Injection of autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.alert.AlertManager
> > com.cloud.ha.HighAvailabilityManagerImpl._alertMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'alertManagerImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: protected com.cloud.capacity.CapacityManager
> > com.cloud.alert.AlertManagerImpl._capacityMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'capacityManagerImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.resource.ResourceManager
> > com.cloud.capacity.CapacityManagerImpl._resourceMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'resourceManagerImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: private com.cloud.vm.VirtualMachineManager
> > com.cloud.resource.ResourceManagerImpl._vmMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'clusteredVirtualMachineManagerImpl': Injection of
> autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field:
> org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager
> > com.cloud.vm.VirtualMachineManagerImpl.dataStoreMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'dataStoreManagerImpl': Injection of autowired
> dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field:
> > org.apache.cloudstack.storage.image.datastore.ImageStoreProviderManager
> >
> org.apache.cloudstack.storage.datastore.DataStoreManagerImpl.imageDataStoreMgr;
> > nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'imageStoreProviderMgr': Injection of autowired
> dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.server.StatsCollector
> >
> org.apache.cloudstack.storage.image.manager.ImageStoreProviderManagerImpl._statsCollector;
> > nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'statsCollector': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: private com.cloud.vm.UserVmManager
> > com.cloud.server.StatsCollector._userVmMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'userVmManagerImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: protected com.cloud.network.NetworkModel
> > com.cloud.vm.UserVmManagerImpl._networkModel; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'networkModelImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.configuration.ConfigurationManager
> > com.cloud.network.NetworkModelImpl._configMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'configurationManagerImpl': Injection of autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field:
> >
> org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService
> > com.cloud.configuration.ConfigurationManagerImpl._networkMgr; nested
> > exception is org.springframework.beans.factory.BeanCreationException:
> Error
> > creating bean with name 'networkOrchestrator': Injection of autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.network.rules.RulesManager
> > org.apache.cloudstack.engine.orchestration.NetworkOrchestrator._rulesMgr;
> > nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'rulesManagerImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.network.IpAddressManager
> > com.cloud.network.rules.RulesManagerImpl._ipAddrMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'ipAddressManagerImpl': Injection of autowired
> dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.network.lb.LoadBalancingRulesManager
> > com.cloud.network.IpAddressManagerImpl._lbMgr; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'loadBalancingRulesManagerImpl': Injection of autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.network.rules.FirewallManager
> > com.cloud.network.lb.LoadBalancingRulesManagerImpl._firewallMgr; nested
> > exception is org.springframework.beans.factory.BeanCreationException:
> Error
> > creating bean with name 'firewallManagerImpl': Injection of autowired
> > dependencies failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.network.vpc.VpcManager
> > com.cloud.network.firewall.FirewallManagerImpl._vpcMgr; nested exception
> is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'vpcManagerImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: com.cloud.network.NetworkService
> > com.cloud.network.vpc.VpcManagerImpl._ntwkSvc; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Error creating
> > bean with name 'networkServiceImpl': Injection of autowired dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field:
> > org.apache.cloudstack.network.element.InternalLoadBalancerElementService
> > com.cloud.network.NetworkServiceImpl._internalLbElementSvc; nested
> > exception is org.springframework.beans.factory.BeanCreationException:
> Error
> > creating bean with name 'InternalLbVm': Injection of autowired
> dependencies
> > failed; nested exception is
> > org.springframework.beans.factory.BeanCreationException: Could not
> autowire
> > field: private com.cloud.network.element.HAProxyLBRule
> >
> org.apache.cloudstack.network.element.InternalLoadBalancerElement.haProxyLBRule;
> > nested exception is
> > org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> > qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found
> for
> > dependency: expected at least 1 bean which qualifies as autowire
> candidate
> > for this dependency. Dependency annotations: {@javax.inject.Inject()}:
> > > org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> > qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found
> for
> > dependency: expected at least 1 bean which qualifies as autowire
> candidate
> > for this dependency. Dependency annotations: {@javax.inject.Inject()}
> > >    at
> >
> org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoSuchBeanDefinitionException(DefaultListableBeanFactory.java:997)
> > >    at
> >
> org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:867)
> > >    at
> >
> org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:779)
> > >    at
> >
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:498)
> > >    at
> >
> org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
> > >    at
> >
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:295)
> > >    at
> >
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1148)
> > >    at
> >
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519)
> > >    at
> >
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458)
> > >    at
> >
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
> > >
> > >
> > >
> > >> On 29-Aug-2015, at 10:07 AM, Mike Tutkowski <
> > mike.tutkowski@solidfire.com> wrote:
> > >>
> > >> It LGTM. I just updated the PR with that info.
> > >>
> > >> Thanks,
> > >> Mike
> > >>
> > >> On Fri, Aug 28, 2015 at 7:50 PM, Rafael Weingärtner <
> > >> rafaelweingartner@gmail.com> wrote:
> > >>
> > >>> Hi folks,
> > >>> This email is meant to ping the community about the PR (714) that
> > solves
> > >>> the ticket CLOUDSTACK-8750 (
> > >>> https://issues.apache.org/jira/browse/CLOUDSTACK-8750).
> > >>>
> > >>> The commit at first sight might look a bit too big to review, but at
> > the
> > >>> end it is a pretty easy. It will remove a few lines of code while
> > removing
> > >>> some issues on Sonar code analysis.
> > >>> If I am not mistaken @DaanHoogland has already given a LGTM in a past
> > mail
> > >>> about this PR.
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Rafael Weingärtner
> > >>
> > >>
> > >>
> > >> --
> > >> *Mike Tutkowski*
> > >> *Senior CloudStack Developer, SolidFire Inc.*
> > >> e: mike.tutkowski@solidfire.com
> > >> o: 303.746.7302
> > >> Advancing the way the world uses the cloud
> > >> <http://solidfire.com/solution/overview/?video=play>*™*
> > >
> >
>



-- 
Rafael Weingärtner

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Rajani Karuturi <ra...@apache.org>.
I am doing a build with revert locally. Will revert once done.

~Rajani

On Mon, Aug 31, 2015 at 11:11 AM, Remi Bergsma <RB...@schubergphilis.com>
wrote:

> I say we revert so the 4.6 testing can continue and then work on fixing
> why this broke the build. No hard feelings, we simply need master to build.
>
> If someone can revert, please do. I can do it in about two hours.
>
> Sent from my iPhone
>
> > On 31 Aug 2015, at 06:58, Koushik Das <ko...@citrix.com> wrote:
> >
> > I am no longer able to start MS after this. I did a clean build followed
> by starting MS. Did travis pass for it? Should we revert?
> >
> >> mvn clean install -Dsimulator -DskipTests
> >> mvn -pl client jetty:run -Dsimulator
> >
> > Getting the following error. No qualifying bean of type
> [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at
> least 1 bean which qualifies as autowire candidate for this dependency.
> >
> > 2015-08-31 09:51:29.195:WARN::Nested in
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'accountManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private com.cloud.storage.dao.VMTemplateDao
> com.cloud.user.AccountManagerImpl._templateDao; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'VMTemplateDaoImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao
> com.cloud.storage.dao.VMTemplateDaoImpl._templateDataStoreDao; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'templateDataStoreDaoImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private
> org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager
> org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl._storeMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'dataStoreProviderManager': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field:
> org.apache.cloudstack.storage.datastore.PrimaryDataStoreProviderManager
> org.apache.cloudstack.storage.datastore.provider.DataStoreProviderManagerImpl.primaryDataStoreProviderMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'primaryDataStoreProviderMgr': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.storage.StorageManager
> org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.storageMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'storageManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: protected com.cloud.agent.AgentManager
> com.cloud.storage.StorageManagerImpl._agentMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'clusteredAgentManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: protected com.cloud.ha.HighAvailabilityManager
> com.cloud.agent.manager.AgentManagerImpl._haMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'highAvailabilityManagerExtImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.alert.AlertManager
> com.cloud.ha.HighAvailabilityManagerImpl._alertMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'alertManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: protected com.cloud.capacity.CapacityManager
> com.cloud.alert.AlertManagerImpl._capacityMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'capacityManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.resource.ResourceManager
> com.cloud.capacity.CapacityManagerImpl._resourceMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'resourceManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private com.cloud.vm.VirtualMachineManager
> com.cloud.resource.ResourceManagerImpl._vmMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'clusteredVirtualMachineManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager
> com.cloud.vm.VirtualMachineManagerImpl.dataStoreMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'dataStoreManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field:
> org.apache.cloudstack.storage.image.datastore.ImageStoreProviderManager
> org.apache.cloudstack.storage.datastore.DataStoreManagerImpl.imageDataStoreMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'imageStoreProviderMgr': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.server.StatsCollector
> org.apache.cloudstack.storage.image.manager.ImageStoreProviderManagerImpl._statsCollector;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'statsCollector': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private com.cloud.vm.UserVmManager
> com.cloud.server.StatsCollector._userVmMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'userVmManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: protected com.cloud.network.NetworkModel
> com.cloud.vm.UserVmManagerImpl._networkModel; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'networkModelImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.configuration.ConfigurationManager
> com.cloud.network.NetworkModelImpl._configMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'configurationManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field:
> org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService
> com.cloud.configuration.ConfigurationManagerImpl._networkMgr; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'networkOrchestrator': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.rules.RulesManager
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator._rulesMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'rulesManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.IpAddressManager
> com.cloud.network.rules.RulesManagerImpl._ipAddrMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'ipAddressManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.lb.LoadBalancingRulesManager
> com.cloud.network.IpAddressManagerImpl._lbMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'loadBalancingRulesManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.rules.FirewallManager
> com.cloud.network.lb.LoadBalancingRulesManagerImpl._firewallMgr; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'firewallManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.vpc.VpcManager
> com.cloud.network.firewall.FirewallManagerImpl._vpcMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'vpcManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.NetworkService
> com.cloud.network.vpc.VpcManagerImpl._ntwkSvc; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'networkServiceImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field:
> org.apache.cloudstack.network.element.InternalLoadBalancerElementService
> com.cloud.network.NetworkServiceImpl._internalLbElementSvc; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'InternalLbVm': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private com.cloud.network.element.HAProxyLBRule
> org.apache.cloudstack.network.element.InternalLoadBalancerElement.haProxyLBRule;
> nested exception is
> org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for
> dependency: expected at least 1 bean which qualifies as autowire candidate
> for this dependency. Dependency annotations: {@javax.inject.Inject()}:
> > org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for
> dependency: expected at least 1 bean which qualifies as autowire candidate
> for this dependency. Dependency annotations: {@javax.inject.Inject()}
> >    at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoSuchBeanDefinitionException(DefaultListableBeanFactory.java:997)
> >    at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:867)
> >    at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:779)
> >    at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:498)
> >    at
> org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
> >    at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:295)
> >    at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1148)
> >    at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519)
> >    at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458)
> >    at
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
> >
> >
> >
> >> On 29-Aug-2015, at 10:07 AM, Mike Tutkowski <
> mike.tutkowski@solidfire.com> wrote:
> >>
> >> It LGTM. I just updated the PR with that info.
> >>
> >> Thanks,
> >> Mike
> >>
> >> On Fri, Aug 28, 2015 at 7:50 PM, Rafael Weingärtner <
> >> rafaelweingartner@gmail.com> wrote:
> >>
> >>> Hi folks,
> >>> This email is meant to ping the community about the PR (714) that
> solves
> >>> the ticket CLOUDSTACK-8750 (
> >>> https://issues.apache.org/jira/browse/CLOUDSTACK-8750).
> >>>
> >>> The commit at first sight might look a bit too big to review, but at
> the
> >>> end it is a pretty easy. It will remove a few lines of code while
> removing
> >>> some issues on Sonar code analysis.
> >>> If I am not mistaken @DaanHoogland has already given a LGTM in a past
> mail
> >>> about this PR.
> >>>
> >>>
> >>>
> >>> --
> >>> Rafael Weingärtner
> >>
> >>
> >>
> >> --
> >> *Mike Tutkowski*
> >> *Senior CloudStack Developer, SolidFire Inc.*
> >> e: mike.tutkowski@solidfire.com
> >> o: 303.746.7302
> >> Advancing the way the world uses the cloud
> >> <http://solidfire.com/solution/overview/?video=play>*™*
> >
>

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Remi Bergsma <RB...@schubergphilis.com>.
I say we revert so the 4.6 testing can continue and then work on fixing why this broke the build. No hard feelings, we simply need master to build. 

If someone can revert, please do. I can do it in about two hours. 

Sent from my iPhone

> On 31 Aug 2015, at 06:58, Koushik Das <ko...@citrix.com> wrote:
> 
> I am no longer able to start MS after this. I did a clean build followed by starting MS. Did travis pass for it? Should we revert? 
> 
>> mvn clean install -Dsimulator -DskipTests
>> mvn -pl client jetty:run -Dsimulator
> 
> Getting the following error. No qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency.
> 
> 2015-08-31 09:51:29.195:WARN::Nested in org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'accountManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.cloud.storage.dao.VMTemplateDao com.cloud.user.AccountManagerImpl._templateDao; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'VMTemplateDaoImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao com.cloud.storage.dao.VMTemplateDaoImpl._templateDataStoreDao; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'templateDataStoreDaoImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl._storeMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataStoreProviderManager': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.storage.datastore.PrimaryDataStoreProviderManager org.apache.cloudstack.storage.datastore.provider.DataStoreProviderManagerImpl.primaryDataStoreProviderMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'primaryDataStoreProviderMgr': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.storage.StorageManager org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.storageMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'storageManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: protected com.cloud.agent.AgentManager com.cloud.storage.StorageManagerImpl._agentMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clusteredAgentManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: protected com.cloud.ha.HighAvailabilityManager com.cloud.agent.manager.AgentManagerImpl._haMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'highAvailabilityManagerExtImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.alert.AlertManager com.cloud.ha.HighAvailabilityManagerImpl._alertMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'alertManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: protected com.cloud.capacity.CapacityManager com.cloud.alert.AlertManagerImpl._capacityMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'capacityManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.resource.ResourceManager com.cloud.capacity.CapacityManagerImpl._resourceMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'resourceManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.cloud.vm.VirtualMachineManager com.cloud.resource.ResourceManagerImpl._vmMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clusteredVirtualMachineManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager com.cloud.vm.VirtualMachineManagerImpl.dataStoreMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataStoreManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.storage.image.datastore.ImageStoreProviderManager org.apache.cloudstack.storage.datastore.DataStoreManagerImpl.imageDataStoreMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'imageStoreProviderMgr': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.server.StatsCollector org.apache.cloudstack.storage.image.manager.ImageStoreProviderManagerImpl._statsCollector; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'statsCollector': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.cloud.vm.UserVmManager com.cloud.server.StatsCollector._userVmMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'userVmManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: protected com.cloud.network.NetworkModel com.cloud.vm.UserVmManagerImpl._networkModel; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'networkModelImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.configuration.ConfigurationManager com.cloud.network.NetworkModelImpl._configMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'configurationManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService com.cloud.configuration.ConfigurationManagerImpl._networkMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'networkOrchestrator': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.rules.RulesManager org.apache.cloudstack.engine.orchestration.NetworkOrchestrator._rulesMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'rulesManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.IpAddressManager com.cloud.network.rules.RulesManagerImpl._ipAddrMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'ipAddressManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.lb.LoadBalancingRulesManager com.cloud.network.IpAddressManagerImpl._lbMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'loadBalancingRulesManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.rules.FirewallManager com.cloud.network.lb.LoadBalancingRulesManagerImpl._firewallMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'firewallManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.vpc.VpcManager com.cloud.network.firewall.FirewallManagerImpl._vpcMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'vpcManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.NetworkService com.cloud.network.vpc.VpcManagerImpl._ntwkSvc; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'networkServiceImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.network.element.InternalLoadBalancerElementService com.cloud.network.NetworkServiceImpl._internalLbElementSvc; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'InternalLbVm': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.cloud.network.element.HAProxyLBRule org.apache.cloudstack.network.element.InternalLoadBalancerElement.haProxyLBRule; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {@javax.inject.Inject()}:
> org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {@javax.inject.Inject()}
>    at org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoSuchBeanDefinitionException(DefaultListableBeanFactory.java:997)
>    at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:867)
>    at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:779)
>    at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:498)
>    at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
>    at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:295)
>    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1148)
>    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519)
>    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458)
>    at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
> 
> 
> 
>> On 29-Aug-2015, at 10:07 AM, Mike Tutkowski <mi...@solidfire.com> wrote:
>> 
>> It LGTM. I just updated the PR with that info.
>> 
>> Thanks,
>> Mike
>> 
>> On Fri, Aug 28, 2015 at 7:50 PM, Rafael Weingärtner <
>> rafaelweingartner@gmail.com> wrote:
>> 
>>> Hi folks,
>>> This email is meant to ping the community about the PR (714) that solves
>>> the ticket CLOUDSTACK-8750 (
>>> https://issues.apache.org/jira/browse/CLOUDSTACK-8750).
>>> 
>>> The commit at first sight might look a bit too big to review, but at the
>>> end it is a pretty easy. It will remove a few lines of code while removing
>>> some issues on Sonar code analysis.
>>> If I am not mistaken @DaanHoogland has already given a LGTM in a past mail
>>> about this PR.
>>> 
>>> 
>>> 
>>> --
>>> Rafael Weingärtner
>> 
>> 
>> 
>> -- 
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkowski@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the cloud
>> <http://solidfire.com/solution/overview/?video=play>*™*
>

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Mike Tutkowski <mi...@solidfire.com>.
In fact, the JIRA ticket is listed as "Minor". At this point in 4.6, I
don't think we want to merge in code for tickets listed as "Minor".

Perhaps Remi can confirm or deny that.

On Sun, Aug 30, 2015 at 11:03 PM, Mike Tutkowski <
mike.tutkowski@solidfire.com> wrote:

> I would say, yeah, revert it. Daan and I did a visual walk through of the
> code, but I don't think either of us did a build and tried to run it. I
> thought the tests said they were good on Travis, though.
>
> On Sun, Aug 30, 2015 at 10:57 PM, Koushik Das <ko...@citrix.com>
> wrote:
>
>> I am no longer able to start MS after this. I did a clean build followed
>> by starting MS. Did travis pass for it? Should we revert?
>>
>> > mvn clean install -Dsimulator -DskipTests
>> > mvn -pl client jetty:run -Dsimulator
>>
>> Getting the following error. No qualifying bean of type
>> [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at
>> least 1 bean which qualifies as autowire candidate for this dependency.
>>
>> 2015-08-31 09:51:29.195:WARN::Nested in
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'accountManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: private com.cloud.storage.dao.VMTemplateDao
>> com.cloud.user.AccountManagerImpl._templateDao; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'VMTemplateDaoImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao
>> com.cloud.storage.dao.VMTemplateDaoImpl._templateDataStoreDao; nested
>> exception is org.springframework.beans.factory.BeanCreationException: Error
>> creating bean with name 'templateDataStoreDaoImpl': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: private
>> org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager
>> org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl._storeMgr;
>> nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'dataStoreProviderManager': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field:
>> org.apache.cloudstack.storage.datastore.PrimaryDataStoreProviderManager
>> org.apache.cloudstack.storage.datastore.provider.DataStoreProviderManagerImpl.primaryDataStoreProviderMgr;
>> nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'primaryDataStoreProviderMgr': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.storage.StorageManager
>> org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.storageMgr;
>> nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'storageManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: protected com.cloud.agent.AgentManager
>> com.cloud.storage.StorageManagerImpl._agentMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'clusteredAgentManagerImpl': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: protected com.cloud.ha.HighAvailabilityManager
>> com.cloud.agent.manager.AgentManagerImpl._haMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'highAvailabilityManagerExtImpl': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.alert.AlertManager
>> com.cloud.ha.HighAvailabilityManagerImpl._alertMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'alertManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: protected com.cloud.capacity.CapacityManager
>> com.cloud.alert.AlertManagerImpl._capacityMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'capacityManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.resource.ResourceManager
>> com.cloud.capacity.CapacityManagerImpl._resourceMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'resourceManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: private com.cloud.vm.VirtualMachineManager
>> com.cloud.resource.ResourceManagerImpl._vmMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'clusteredVirtualMachineManagerImpl': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager
>> com.cloud.vm.VirtualMachineManagerImpl.dataStoreMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'dataStoreManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field:
>> org.apache.cloudstack.storage.image.datastore.ImageStoreProviderManager
>> org.apache.cloudstack.storage.datastore.DataStoreManagerImpl.imageDataStoreMgr;
>> nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'imageStoreProviderMgr': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.server.StatsCollector
>> org.apache.cloudstack.storage.image.manager.ImageStoreProviderManagerImpl._statsCollector;
>> nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'statsCollector': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: private com.cloud.vm.UserVmManager
>> com.cloud.server.StatsCollector._userVmMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'userVmManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: protected com.cloud.network.NetworkModel
>> com.cloud.vm.UserVmManagerImpl._networkModel; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'networkModelImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.configuration.ConfigurationManager
>> com.cloud.network.NetworkModelImpl._configMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'configurationManagerImpl': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field:
>> org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService
>> com.cloud.configuration.ConfigurationManagerImpl._networkMgr; nested
>> exception is org.springframework.beans.factory.BeanCreationException: Error
>> creating bean with name 'networkOrchestrator': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.network.rules.RulesManager
>> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator._rulesMgr;
>> nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'rulesManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.network.IpAddressManager
>> com.cloud.network.rules.RulesManagerImpl._ipAddrMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'ipAddressManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.network.lb.LoadBalancingRulesManager
>> com.cloud.network.IpAddressManagerImpl._lbMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'loadBalancingRulesManagerImpl': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.network.rules.FirewallManager
>> com.cloud.network.lb.LoadBalancingRulesManagerImpl._firewallMgr; nested
>> exception is org.springframework.beans.factory.BeanCreationException: Error
>> creating bean with name 'firewallManagerImpl': Injection of autowired
>> dependencies failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.network.vpc.VpcManager
>> com.cloud.network.firewall.FirewallManagerImpl._vpcMgr; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'vpcManagerImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: com.cloud.network.NetworkService
>> com.cloud.network.vpc.VpcManagerImpl._ntwkSvc; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Error creating
>> bean with name 'networkServiceImpl': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field:
>> org.apache.cloudstack.network.element.InternalLoadBalancerElementService
>> com.cloud.network.NetworkServiceImpl._internalLbElementSvc; nested
>> exception is org.springframework.beans.factory.BeanCreationException: Error
>> creating bean with name 'InternalLbVm': Injection of autowired dependencies
>> failed; nested exception is
>> org.springframework.beans.factory.BeanCreationException: Could not autowire
>> field: private com.cloud.network.element.HAProxyLBRule
>> org.apache.cloudstack.network.element.InternalLoadBalancerElement.haProxyLBRule;
>> nested exception is
>> org.springframework.beans.factory.NoSuchBeanDefinitionException: No
>> qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for
>> dependency: expected at least 1 bean which qualifies as autowire candidate
>> for this dependency. Dependency annotations: {@javax.inject.Inject()}:
>> org.springframework.beans.factory.NoSuchBeanDefinitionException: No
>> qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for
>> dependency: expected at least 1 bean which qualifies as autowire candidate
>> for this dependency. Dependency annotations: {@javax.inject.Inject()}
>>         at
>> org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoSuchBeanDefinitionException(DefaultListableBeanFactory.java:997)
>>         at
>> org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:867)
>>         at
>> org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:779)
>>         at
>> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:498)
>>         at
>> org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
>>         at
>> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:295)
>>         at
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1148)
>>         at
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519)
>>         at
>> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458)
>>         at
>> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
>>
>>
>>
>> On 29-Aug-2015, at 10:07 AM, Mike Tutkowski <mi...@solidfire.com>
>> wrote:
>>
>> > It LGTM. I just updated the PR with that info.
>> >
>> > Thanks,
>> > Mike
>> >
>> > On Fri, Aug 28, 2015 at 7:50 PM, Rafael Weingärtner <
>> > rafaelweingartner@gmail.com> wrote:
>> >
>> >> Hi folks,
>> >> This email is meant to ping the community about the PR (714) that
>> solves
>> >> the ticket CLOUDSTACK-8750 (
>> >> https://issues.apache.org/jira/browse/CLOUDSTACK-8750).
>> >>
>> >> The commit at first sight might look a bit too big to review, but at
>> the
>> >> end it is a pretty easy. It will remove a few lines of code while
>> removing
>> >> some issues on Sonar code analysis.
>> >> If I am not mistaken @DaanHoogland has already given a LGTM in a past
>> mail
>> >> about this PR.
>> >>
>> >>
>> >>
>> >> --
>> >> Rafael Weingärtner
>> >>
>> >
>> >
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkowski@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the cloud
>> > <http://solidfire.com/solution/overview/?video=play>*™*
>>
>>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*

Re: [BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Mike Tutkowski <mi...@solidfire.com>.
I would say, yeah, revert it. Daan and I did a visual walk through of the
code, but I don't think either of us did a build and tried to run it. I
thought the tests said they were good on Travis, though.

On Sun, Aug 30, 2015 at 10:57 PM, Koushik Das <ko...@citrix.com>
wrote:

> I am no longer able to start MS after this. I did a clean build followed
> by starting MS. Did travis pass for it? Should we revert?
>
> > mvn clean install -Dsimulator -DskipTests
> > mvn -pl client jetty:run -Dsimulator
>
> Getting the following error. No qualifying bean of type
> [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at
> least 1 bean which qualifies as autowire candidate for this dependency.
>
> 2015-08-31 09:51:29.195:WARN::Nested in
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'accountManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private com.cloud.storage.dao.VMTemplateDao
> com.cloud.user.AccountManagerImpl._templateDao; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'VMTemplateDaoImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao
> com.cloud.storage.dao.VMTemplateDaoImpl._templateDataStoreDao; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'templateDataStoreDaoImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private
> org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager
> org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl._storeMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'dataStoreProviderManager': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field:
> org.apache.cloudstack.storage.datastore.PrimaryDataStoreProviderManager
> org.apache.cloudstack.storage.datastore.provider.DataStoreProviderManagerImpl.primaryDataStoreProviderMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'primaryDataStoreProviderMgr': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.storage.StorageManager
> org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.storageMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'storageManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: protected com.cloud.agent.AgentManager
> com.cloud.storage.StorageManagerImpl._agentMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'clusteredAgentManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: protected com.cloud.ha.HighAvailabilityManager
> com.cloud.agent.manager.AgentManagerImpl._haMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'highAvailabilityManagerExtImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.alert.AlertManager
> com.cloud.ha.HighAvailabilityManagerImpl._alertMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'alertManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: protected com.cloud.capacity.CapacityManager
> com.cloud.alert.AlertManagerImpl._capacityMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'capacityManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.resource.ResourceManager
> com.cloud.capacity.CapacityManagerImpl._resourceMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'resourceManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private com.cloud.vm.VirtualMachineManager
> com.cloud.resource.ResourceManagerImpl._vmMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'clusteredVirtualMachineManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager
> com.cloud.vm.VirtualMachineManagerImpl.dataStoreMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'dataStoreManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field:
> org.apache.cloudstack.storage.image.datastore.ImageStoreProviderManager
> org.apache.cloudstack.storage.datastore.DataStoreManagerImpl.imageDataStoreMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'imageStoreProviderMgr': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.server.StatsCollector
> org.apache.cloudstack.storage.image.manager.ImageStoreProviderManagerImpl._statsCollector;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'statsCollector': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private com.cloud.vm.UserVmManager
> com.cloud.server.StatsCollector._userVmMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'userVmManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: protected com.cloud.network.NetworkModel
> com.cloud.vm.UserVmManagerImpl._networkModel; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'networkModelImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.configuration.ConfigurationManager
> com.cloud.network.NetworkModelImpl._configMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'configurationManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field:
> org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService
> com.cloud.configuration.ConfigurationManagerImpl._networkMgr; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'networkOrchestrator': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.rules.RulesManager
> org.apache.cloudstack.engine.orchestration.NetworkOrchestrator._rulesMgr;
> nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'rulesManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.IpAddressManager
> com.cloud.network.rules.RulesManagerImpl._ipAddrMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'ipAddressManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.lb.LoadBalancingRulesManager
> com.cloud.network.IpAddressManagerImpl._lbMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'loadBalancingRulesManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.rules.FirewallManager
> com.cloud.network.lb.LoadBalancingRulesManagerImpl._firewallMgr; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'firewallManagerImpl': Injection of autowired
> dependencies failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.vpc.VpcManager
> com.cloud.network.firewall.FirewallManagerImpl._vpcMgr; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'vpcManagerImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: com.cloud.network.NetworkService
> com.cloud.network.vpc.VpcManagerImpl._ntwkSvc; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'networkServiceImpl': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field:
> org.apache.cloudstack.network.element.InternalLoadBalancerElementService
> com.cloud.network.NetworkServiceImpl._internalLbElementSvc; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'InternalLbVm': Injection of autowired dependencies
> failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Could not autowire
> field: private com.cloud.network.element.HAProxyLBRule
> org.apache.cloudstack.network.element.InternalLoadBalancerElement.haProxyLBRule;
> nested exception is
> org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for
> dependency: expected at least 1 bean which qualifies as autowire candidate
> for this dependency. Dependency annotations: {@javax.inject.Inject()}:
> org.springframework.beans.factory.NoSuchBeanDefinitionException: No
> qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for
> dependency: expected at least 1 bean which qualifies as autowire candidate
> for this dependency. Dependency annotations: {@javax.inject.Inject()}
>         at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoSuchBeanDefinitionException(DefaultListableBeanFactory.java:997)
>         at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:867)
>         at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:779)
>         at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:498)
>         at
> org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
>         at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:295)
>         at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1148)
>         at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519)
>         at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458)
>         at
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
>
>
>
> On 29-Aug-2015, at 10:07 AM, Mike Tutkowski <mi...@solidfire.com>
> wrote:
>
> > It LGTM. I just updated the PR with that info.
> >
> > Thanks,
> > Mike
> >
> > On Fri, Aug 28, 2015 at 7:50 PM, Rafael Weingärtner <
> > rafaelweingartner@gmail.com> wrote:
> >
> >> Hi folks,
> >> This email is meant to ping the community about the PR (714) that solves
> >> the ticket CLOUDSTACK-8750 (
> >> https://issues.apache.org/jira/browse/CLOUDSTACK-8750).
> >>
> >> The commit at first sight might look a bit too big to review, but at the
> >> end it is a pretty easy. It will remove a few lines of code while
> removing
> >> some issues on Sonar code analysis.
> >> If I am not mistaken @DaanHoogland has already given a LGTM in a past
> mail
> >> about this PR.
> >>
> >>
> >>
> >> --
> >> Rafael Weingärtner
> >>
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkowski@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > <http://solidfire.com/solution/overview/?video=play>*™*
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*

[BLOCKER] Master broken due to PR 714 (CLOUDSTACK-8750)

Posted by Koushik Das <ko...@citrix.com>.
I am no longer able to start MS after this. I did a clean build followed by starting MS. Did travis pass for it? Should we revert? 

> mvn clean install -Dsimulator -DskipTests
> mvn -pl client jetty:run -Dsimulator

Getting the following error. No qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency.

2015-08-31 09:51:29.195:WARN::Nested in org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'accountManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.cloud.storage.dao.VMTemplateDao com.cloud.user.AccountManagerImpl._templateDao; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'VMTemplateDaoImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.storage.datastore.db.TemplateDataStoreDao com.cloud.storage.dao.VMTemplateDaoImpl._templateDataStoreDao; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'templateDataStoreDaoImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager org.apache.cloudstack.storage.image.db.TemplateDataStoreDaoImpl._storeMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataStoreProviderManager': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.storage.datastore.PrimaryDataStoreProviderManager org.apache.cloudstack.storage.datastore.provider.DataStoreProviderManagerImpl.primaryDataStoreProviderMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'primaryDataStoreProviderMgr': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.storage.StorageManager org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.storageMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'storageManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: protected com.cloud.agent.AgentManager com.cloud.storage.StorageManagerImpl._agentMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clusteredAgentManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: protected com.cloud.ha.HighAvailabilityManager com.cloud.agent.manager.AgentManagerImpl._haMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'highAvailabilityManagerExtImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.alert.AlertManager com.cloud.ha.HighAvailabilityManagerImpl._alertMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'alertManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: protected com.cloud.capacity.CapacityManager com.cloud.alert.AlertManagerImpl._capacityMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'capacityManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.resource.ResourceManager com.cloud.capacity.CapacityManagerImpl._resourceMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'resourceManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.cloud.vm.VirtualMachineManager com.cloud.resource.ResourceManagerImpl._vmMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clusteredVirtualMachineManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager com.cloud.vm.VirtualMachineManagerImpl.dataStoreMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'dataStoreManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.storage.image.datastore.ImageStoreProviderManager org.apache.cloudstack.storage.datastore.DataStoreManagerImpl.imageDataStoreMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'imageStoreProviderMgr': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.server.StatsCollector org.apache.cloudstack.storage.image.manager.ImageStoreProviderManagerImpl._statsCollector; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'statsCollector': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.cloud.vm.UserVmManager com.cloud.server.StatsCollector._userVmMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'userVmManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: protected com.cloud.network.NetworkModel com.cloud.vm.UserVmManagerImpl._networkModel; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'networkModelImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.configuration.ConfigurationManager com.cloud.network.NetworkModelImpl._configMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'configurationManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.engine.orchestration.service.NetworkOrchestrationService com.cloud.configuration.ConfigurationManagerImpl._networkMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'networkOrchestrator': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.rules.RulesManager org.apache.cloudstack.engine.orchestration.NetworkOrchestrator._rulesMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'rulesManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.IpAddressManager com.cloud.network.rules.RulesManagerImpl._ipAddrMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'ipAddressManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.lb.LoadBalancingRulesManager com.cloud.network.IpAddressManagerImpl._lbMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'loadBalancingRulesManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.rules.FirewallManager com.cloud.network.lb.LoadBalancingRulesManagerImpl._firewallMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'firewallManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.vpc.VpcManager com.cloud.network.firewall.FirewallManagerImpl._vpcMgr; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'vpcManagerImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: com.cloud.network.NetworkService com.cloud.network.vpc.VpcManagerImpl._ntwkSvc; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'networkServiceImpl': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.apache.cloudstack.network.element.InternalLoadBalancerElementService com.cloud.network.NetworkServiceImpl._internalLbElementSvc; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'InternalLbVm': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private com.cloud.network.element.HAProxyLBRule org.apache.cloudstack.network.element.InternalLoadBalancerElement.haProxyLBRule; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {@javax.inject.Inject()}:
org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type [com.cloud.network.element.HAProxyLBRule] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {@javax.inject.Inject()}
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoSuchBeanDefinitionException(DefaultListableBeanFactory.java:997)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:867)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:779)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:498)
	at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:295)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1148)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:458)
	at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)



On 29-Aug-2015, at 10:07 AM, Mike Tutkowski <mi...@solidfire.com> wrote:

> It LGTM. I just updated the PR with that info.
> 
> Thanks,
> Mike
> 
> On Fri, Aug 28, 2015 at 7:50 PM, Rafael Weingärtner <
> rafaelweingartner@gmail.com> wrote:
> 
>> Hi folks,
>> This email is meant to ping the community about the PR (714) that solves
>> the ticket CLOUDSTACK-8750 (
>> https://issues.apache.org/jira/browse/CLOUDSTACK-8750).
>> 
>> The commit at first sight might look a bit too big to review, but at the
>> end it is a pretty easy. It will remove a few lines of code while removing
>> some issues on Sonar code analysis.
>> If I am not mistaken @DaanHoogland has already given a LGTM in a past mail
>> about this PR.
>> 
>> 
>> 
>> --
>> Rafael Weingärtner
>> 
> 
> 
> 
> -- 
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*™*

Re: Review wanted for PR 714 (CLOUDSTACK-8750)

Posted by Mike Tutkowski <mi...@solidfire.com>.
It LGTM. I just updated the PR with that info.

Thanks,
Mike

On Fri, Aug 28, 2015 at 7:50 PM, Rafael Weingärtner <
rafaelweingartner@gmail.com> wrote:

> Hi folks,
> This email is meant to ping the community about the PR (714) that solves
> the ticket CLOUDSTACK-8750 (
> https://issues.apache.org/jira/browse/CLOUDSTACK-8750).
>
> The commit at first sight might look a bit too big to review, but at the
> end it is a pretty easy. It will remove a few lines of code while removing
> some issues on Sonar code analysis.
> If I am not mistaken @DaanHoogland has already given a LGTM in a past mail
> about this PR.
>
>
>
> --
> Rafael Weingärtner
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*