You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2025/07/20 18:38:34 UTC

[PR] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

turboFei opened a new pull request, #3376:
URL: https://github.com/apache/celeborn/pull/3376

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3376:
URL: https://github.com/apache/celeborn/pull/3376#issuecomment-3101949574

   Merged to main(v0.7.0) and branch-0.6(v0.6.1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3376:
URL: https://github.com/apache/celeborn/pull/3376#discussion_r2217921364


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala:
##########
@@ -580,19 +588,22 @@ class FetchHandler(
         streamChunkSlice.chunkIndex,
         streamChunkSlice.offset,
         streamChunkSlice.len)
+      val bufSize = buf.size()
       chunkStreamManager.chunkBeingSent(streamChunkSlice.streamId)
       client.getChannel.writeAndFlush(new ChunkFetchSuccess(streamChunkSlice, buf))
         .addListener(new GenericFutureListener[Future[_ >: Void]] {
           override def operationComplete(future: Future[_ >: Void]): Unit = {
             if (future.isSuccess) {
               if (log.isDebugEnabled) {
                 logDebug(
-                  s"Sending ChunkFetchSuccess to $remoteAddr succeeded, chunk $streamChunkSlice")
+                  s"Sending ChunkFetchSuccess to $remoteAddr succeeded," +
+                    s" chunk $streamChunkSlice, buf size: $bufSize")

Review Comment:
   minor change for real chunk size, for `streamChunkSlice`, its length is always Int.MaxValue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #3376:
URL: https://github.com/apache/celeborn/pull/3376#issuecomment-3097672351

   > @turboFei, with the changes of `OpenStreamTime` calculation, the `OpenStreamTime` metric records the time of each `OpenStreamRequest` instead of each shuffle key, right?
   
   Have updated the code, thanks @SteNicholas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3376: [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request
URL: https://github.com/apache/celeborn/pull/3376


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3376:
URL: https://github.com/apache/celeborn/pull/3376#discussion_r2217921364


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala:
##########
@@ -580,19 +588,22 @@ class FetchHandler(
         streamChunkSlice.chunkIndex,
         streamChunkSlice.offset,
         streamChunkSlice.len)
+      val bufSize = buf.size()
       chunkStreamManager.chunkBeingSent(streamChunkSlice.streamId)
       client.getChannel.writeAndFlush(new ChunkFetchSuccess(streamChunkSlice, buf))
         .addListener(new GenericFutureListener[Future[_ >: Void]] {
           override def operationComplete(future: Future[_ >: Void]): Unit = {
             if (future.isSuccess) {
               if (log.isDebugEnabled) {
                 logDebug(
-                  s"Sending ChunkFetchSuccess to $remoteAddr succeeded, chunk $streamChunkSlice")
+                  s"Sending ChunkFetchSuccess to $remoteAddr succeeded," +
+                    s" chunk $streamChunkSlice, buf size: $bufSize")

Review Comment:
   minor change for real chunk size, for `streamChunkSlice`, its length is always Int.MaxValue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3376:
URL: https://github.com/apache/celeborn/pull/3376#issuecomment-3094720656

   ## [Codecov](https://app.codecov.io/gh/apache/celeborn/pull/3376?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   > Project coverage is 63.63%. Comparing base [(`8ae9737`)](https://app.codecov.io/gh/apache/celeborn/commit/8ae97376010c191293d3dd5ae5f39aba5692eb57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7e645bb`)](https://app.codecov.io/gh/apache/celeborn/commit/7e645bbf1f8e66d3366e579a557f3de4feee0b74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 14 commits behind head on main.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/celeborn/pull/3376?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [.../scala/org/apache/celeborn/common/util/Utils.scala](https://app.codecov.io/gh/apache/celeborn/pull/3376?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fceleborn%2Fcommon%2Futil%2FUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3V0aWwvVXRpbHMuc2NhbGE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/celeborn/pull/3376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #3376      +/-   ##
   ==========================================
   + Coverage   63.57%   63.63%   +0.06%     
   ==========================================
     Files         348      351       +3     
     Lines       21300    21490     +190     
     Branches     1879     1897      +18     
   ==========================================
   + Hits        13539    13672     +133     
   - Misses       6781     6821      +40     
   - Partials      980      997      +17     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celeborn/pull/3376?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3376:
URL: https://github.com/apache/celeborn/pull/3376#discussion_r2218419179


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -1280,6 +1280,14 @@ object Utils extends Logging {
     s"$shuffleKey-$clientChannelId-$rpcRequestId"
   }
 
+  def makeOpenStreamListRequestId(
+      shuffleKey: String,
+      clientChannelId: String,
+      rpcRequestId: Long,
+      idx: Int): String = {
+    s"$shuffleKey-$clientChannelId-$rpcRequestId-$idx"

Review Comment:
   ```suggestion
       s"$makeOpenStreamRequestId(shuffleKey, clientChannelId, rpcRequestId)-$idx"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3376:
URL: https://github.com/apache/celeborn/pull/3376#issuecomment-3095670881

   @turboFei, with the changes of `OpenStreamTime` calculation, the `OpenStreamTime` metric records the time of each `OpenStreamRequest` instead of each shuffle key, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-2075] Fix `OpenStreamTime` metrics for `PbOpenStreamList` request [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3376:
URL: https://github.com/apache/celeborn/pull/3376#discussion_r2218419179


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -1280,6 +1280,14 @@ object Utils extends Logging {
     s"$shuffleKey-$clientChannelId-$rpcRequestId"
   }
 
+  def makeOpenStreamListRequestId(
+      shuffleKey: String,
+      clientChannelId: String,
+      rpcRequestId: Long,
+      idx: Int): String = {
+    s"$shuffleKey-$clientChannelId-$rpcRequestId-$idx"

Review Comment:
   ```suggestion
       s"${makeOpenStreamRequestId(shuffleKey, clientChannelId, rpcRequestId)}-$idx"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org