You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/18 12:44:55 UTC

[GitHub] [airflow] Craig-Chatfield commented on pull request #10373: fix dataflow hook behaviour to not always launch a virtualenv

Craig-Chatfield commented on pull request #10373:
URL: https://github.com/apache/airflow/pull/10373#issuecomment-675455994


   > I think it requires a short note in UPDATING.md but otherwise it is LGTM
   
   @potiuk Can you advise on what the change required should be?
   
   I also see two locations for the hook in `UPDATING.md`:
   https://github.com/apache/airflow/blob/master/UPDATING.md#airflowprovidersgooglecloudhooksdataflowdataflowhook
   https://github.com/apache/airflow/blob/master/UPDATING.md#airflowprovidersgooglecloudhooksdataflowdataflowhook-1
   
   > @potiuk Support for virtual environments has not been released in any release.
   
   @mik-laj Does that hinder this PR? I'm not sure what the implications are.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org