You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/05 16:34:30 UTC

[GitHub] [airflow] romibuzi commented on a diff in pull request #27893: AWSGlueJobHook updates job configuration if it exists

romibuzi commented on code in PR #27893:
URL: https://github.com/apache/airflow/pull/27893#discussion_r1039823808


##########
airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -231,54 +256,72 @@ def job_completion(self, job_name: str, run_id: str, verbose: bool = False) -> d
                         next_token=next_log_token,
                     )
 
-    def get_or_create_glue_job(self) -> str:
+    def get_job(self, job_name) -> dict:

Review Comment:
   Good remark indeed it doesnt make much sense if there is no additionnal logic in these wrappers methods, I have removed them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org