You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/03/11 02:38:03 UTC

[GitHub] [echarts] pissang commented on a change in pull request #16660: feat(event-tree): add `collapsed` to `tree` click event parameters

pissang commented on a change in pull request #16660:
URL: https://github.com/apache/echarts/pull/16660#discussion_r824340680



##########
File path: src/chart/tree/TreeSeries.ts
##########
@@ -240,6 +241,7 @@ class TreeSeriesModel extends SeriesModel<TreeSeriesOption> {
 
         const node = this.getData().tree.getNodeByDataIndex(dataIndex);
         params.treeAncestors = wrapTreePathInfo(node, this);
+        params.collapsed = node.isExpand;

Review comment:
       Should be `params.collapsed = !node.isExpand` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org