You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/21 03:54:06 UTC

[GitHub] [rocketmq] XiaoyiPeng edited a comment on pull request #3509: [ISSUE #2516]: Fix the value of sendThreadPoolQueueHeadWaitTimeMills is 0 most of the time

XiaoyiPeng edited a comment on pull request #3509:
URL: https://github.com/apache/rocketmq/pull/3509#issuecomment-974750856


   > It is also a time-consuming operation to cast all send requests to RequestTask especially when there are many send requests. I think we need to consider whether it is better to isolate the thread pool instead of optimize headslowtimemills.
   
   Thanks for your review.
   However, 
   1. Java streams are executed lazily in the pipeline, when it finds the first task that meets the condition, it will return instead of cast all send requests to RequestTask.
   2. For such a little optimization(we just need `sendThreadPoolQueueHeadWaitTimeMills ` to monitor the load of `BrokerController#sendMessageExecutor`), introduce a new thread pool may be a bit expensive.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org