You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Josersanvil (via GitHub)" <gi...@apache.org> on 2023/02/27 21:09:47 UTC

[GitHub] [airflow] Josersanvil opened a new pull request, #29791: Improve DAG loading in Graph view when using Dynamic Tasks

Josersanvil opened a new pull request, #29791:
URL: https://github.com/apache/airflow/pull/29791

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of an existing issue, reference it using one of the following:

closes: #27483

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

This PR just makes a small change to the function in`www` that loads the DAG view for the Web UI.

Right now, the view loops and retrieves the mapped instances of all the expansions of a single task, that means that if a DAG created 100 expansions of a task instance, it loops through all the 100 expansions in order to retrieve the status of the 100! This makes the loading of that view very slow, and it is also not needed, applying the same logic, we only need to retrieve the mapped instances of one of the expansions to get the status of the rest (Since they all share the same Task Id).

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #29791: Improve DAG loading in Graph view when using Dynamic Tasks

Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.

jedcunningham commented on PR #29791:
URL: https://github.com/apache/airflow/pull/29791#issuecomment-1449174612

   (#protm so @potiuk's nomination gets found by the automation!)
   
   Congrats on your first commit @Josersanvil 🎉


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29791: Improve DAG loading in Graph view when using Dynamic Tasks

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #29791:
URL: https://github.com/apache/airflow/pull/29791#issuecomment-1447093212

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29791: Improve DAG loading in Graph view when using Dynamic Tasks

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #29791:
URL: https://github.com/apache/airflow/pull/29791#issuecomment-1447591111

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi merged pull request #29791: Improve DAG loading in Graph view when using Dynamic Tasks

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.

bbovenzi merged PR #29791:
URL: https://github.com/apache/airflow/pull/29791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pierrejeambrun commented on pull request #29791: Improve DAG loading in Graph view when using Dynamic Tasks

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.

pierrejeambrun commented on PR #29791:
URL: https://github.com/apache/airflow/pull/29791#issuecomment-1447316544

   We might still have an issue with the `try_number`, but this was already the case before. (try_number is shared and will pick the value of the first mapped task to be processed in the `dag.get_task_instances` list)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #29791: Improve DAG loading in Graph view when using Dynamic Tasks

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk commented on PR #29791:
URL: https://github.com/apache/airflow/pull/29791#issuecomment-1447635761

   Sounds like a good candidate for the next PR of the month ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org