You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/03/30 11:50:47 UTC

[Bug 4234] New: rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

http://bugzilla.spamassassin.org/show_bug.cgi?id=4234

           Summary: rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY
                    1.16 causing false positives
           Product: Spamassassin
           Version: 3.0.2
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Rules
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: drakecn@yahoo.com


It makes no sense for MPART_ALT_DIFF to contribute to the score when 
MIME_HTML_ONLY is already doing so - this is resulting in an artifically high 
spam score (causing me false positives.)

If there's no ALT part (eg: it's MIME_HTML_ONLY), testing for MPART_ALT_DIFF 
should be skipped?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4234] rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4234





------- Additional Comments From Bob@Menschel.net  2005-04-08 22:07 -------
Created an attachment (id=2777)
 --> (http://bugzilla.spamassassin.org/attachment.cgi?id=2777&action=view)
email with both rules hitting

Not sure if this sample will help, but this attached email hits MIME_HTML_ONLY,
MIME_HTML_ONLY_MULTI, and MPART_ALT_DIFF



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4234] rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4234





------- Additional Comments From felicity@kluge.net  2005-04-09 10:32 -------
Subject: Re:  rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

On Fri, Apr 08, 2005 at 10:07:33PM -0700, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> Not sure if this sample will help, but this attached email hits MIME_HTML_ONLY,
> MIME_HTML_ONLY_MULTI, and MPART_ALT_DIFF

They're actually different tests, but they end up with the same results for
this specific issue.

MIME_HTML_ONLY says that there are only text/html parts in the message
(ie: no non-text/* parts were found that weren't html...)  MPART_ALT_DIFF
says there's a part that should have text/plain and text/html, but only
has text/html.

MIME_HTML_ONLY just looks at the MIME headers, MPART_ALT_DIFF uses the
rendered type.

In a quick 1 minute thought process about this, the only difference I
can really see is if a multipart/alternative message comes in with a
text/plain part that's really HTML, MPART_ALT_DIFF will catch it, but
MIME_HTML_ONLY won't.


Anyway, I wouldn't be opposed to putting a little check in the eval saying to
return 0 if there weren't any text tokens found.  It already does that if
there are no html tokens found, so it's pretty trivial to modify it.  I'd like
to see the results of both versions before deciding of course. ;)





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4234] rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4234


Bob@Menschel.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |triage






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4234] rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4234


felicity@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.1.1                       |3.1.2






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4234] rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4234


felicity@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From felicity@apache.org  2006-03-15 01:43 -------
hrm.

orig:
19.000  22.0703   1.3403    0.943   0.00    0.42  MPART_ALT_DIFF

skipping text tokens == 0  (no or empty text part)
  1.416   1.6418   0.1200    0.932   1.00    0.42  MPART_ALT_DIFF

and MIME_HTML_ONLY is pretty horrible:
 28.858  32.6913  14.1860    0.697   0.51    0.41  MIME_HTML_ONLY


So in the end, I think the 3.1 score generation solved this for us:

score MIME_HTML_ONLY 0.414 0.001 0.389 0.001
score MPART_ALT_DIFF 0.425 0.137 1.142 0.001

I'm going to close this as fixed -- MPART_ALT_DIFF is doing something different from 
MIME_HTML_ONLY, and both hit a bunch of ham, and the scores reflect that now.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4234] rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4234


Bob@Menschel.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.1.1




------- Additional Comments From Bob@Menschel.net  2005-04-28 20:21 -------
Assigning milestone 3.1.1 based on my interpretation of Theo's comments below.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4234] rule duplication MPART_ALT_DIFF 1.50 and MIME_HTML_ONLY 1.16 causing false positives

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4234





------- Additional Comments From quinlan@pathname.com  2005-03-30 01:58 -------
We really need example messages.  Please attach to the bug.  Don't cut and paste.

Daniel




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.