You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/07/05 22:17:43 UTC

[kudu-CR] Add compile time checks for kerberos, libvmem

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10870


Change subject: Add compile time checks for kerberos, libvmem
......................................................................

Add compile time checks for kerberos, libvmem

This change adds compile time checks for the kerberos and vmem
libraries. These changes will help other projects (e.g. Impala) to
include Kudu code in their own repositories.

For legacy versions of libkrb5.so it includes an implementation of
krb5_is_config_principal().

Change-Id: I0322e44784c026b6d6f1d3088bed03e95e94eb45
---
M CMakeLists.txt
M src/kudu/cfile/cfile-test.cc
M src/kudu/security/CMakeLists.txt
M src/kudu/security/init.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
7 files changed, 63 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/10870/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0322e44784c026b6d6f1d3088bed03e95e94eb45
Gerrit-Change-Number: 10870
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[kudu-CR] Add compile time checks for kerberos, libvmem

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10870 )

Change subject: Add compile time checks for kerberos, libvmem
......................................................................

Add compile time checks for kerberos, libvmem

This change adds compile time checks for the kerberos and vmem
libraries. These changes will help other projects (e.g. Impala) to
include Kudu code in their own repositories.

Change-Id: I0322e44784c026b6d6f1d3088bed03e95e94eb45
Reviewed-on: http://gerrit.cloudera.org:8080/10870
Tested-by: Kudu Jenkins
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M CMakeLists.txt
M src/kudu/cfile/cfile-test.cc
M src/kudu/security/CMakeLists.txt
M src/kudu/security/init.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
7 files changed, 31 insertions(+), 12 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Sailesh Mukil: Looks good to me, but someone else must approve
  Todd Lipcon: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0322e44784c026b6d6f1d3088bed03e95e94eb45
Gerrit-Change-Number: 10870
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>