You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2018/12/16 03:15:54 UTC

[GitHub] guacamole-client pull request #346: GUACAMOLE-680: Rearrange logout handling

GitHub user necouchman opened a pull request:

    https://github.com/apache/guacamole-client/pull/346

    GUACAMOLE-680: Rearrange logout handling

    Per discussion on the mailing list, I've taken a stab at renaming the pre-logout broadcast and implenting a post-logout broadcast in order to set up the possibility that events could be fired by the web application after the Guacamole logout has completed.  No idea if this is what was intended, but took a shot...
    
    [1] - http://mail-archives.apache.org/mod_mbox/guacamole-dev/201812.mbox/%3CCALKeL-O1XQBAGFE17_jgB_OC5%2Bf-uCCEgfOiHbn39XyGRm7s6Q%40mail.gmail.com%3E

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/necouchman/guacamole-client jira/680

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #346
    
----
commit 341335ab7a9a4430728926afa74cfdafe0482aef
Author: Nick Couchman <vn...@...>
Date:   2018-12-16T01:03:56Z

    GUACAMOLE-680: Change guacLogout to beforeGuacLogout.

commit c0a0c869fbc634ea746355c15b5c7965a17a36b1
Author: Nick Couchman <vn...@...>
Date:   2018-12-16T02:58:17Z

    GUACAMOLE-680: Add a broadcast after the logout has been completed.

----


---