You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/15 03:04:37 UTC

[GitHub] [spark] uncleGen commented on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

uncleGen commented on pull request #27694:
URL: https://github.com/apache/spark/pull/27694#issuecomment-643877261


   @HeartSaVioR Thanks for your efforts. The result (version 4) is very impressive. Overall, it makes sense to me. But we should resolve the concern about using `UnsafeRow`. I am not very familiar with the history of discussing about `UnsafeRow`. By the way, is there any value or plan to use this [idea](https://github.com/apache/spark/pull/24128#issuecomment-558548047)? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org