[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1382: MINIFICPP-1899 - Fix local Docker build failure

[GitBox <gi...@apache.org>]

fgerlits commented on code in PR #1382:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1382#discussion_r937927632


##########
libminifi/src/utils/BackTrace.cpp:
##########
@@ -117,6 +117,8 @@ void pull_trace(uint8_t frames_to_skip /* = 1 */) {
 
     TraceResolver::getResolver().addTraceLine(file_name, symbol_name.c_str(), symbol_offset);
   }
+#else
+  (void)(frames_to_skip);

Review Comment:
   It is hard to see what condition this `#else` refers to.  I think
   ```c++
   #ifndef HAS_EXECINFO
   void pull_trace(uint8_t) {}
   #else
   void pull_trace(uint8_t frames_to_skip /* = 1 */) {
   ...
   }
   #endif
   ```
   would be more readable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org