Re: Review Request: Provides an abstraction between implementations and the configurations they use

[Stanton Sievers <si...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2467/
-----------------------------------------------------------

(Updated 2011-10-24 20:26:31.623226)


Review request for shindig, Ryan Baxter, Dan Dumont, and Jesse Ciancetta.


Changes
-------

Adding the dev list.  Pardon the large backlog of discussion.  I wanted to make sure this approach was sane before getting everyone involved.


Summary
-------

This patch adds an abstraction layer between implementations and configuration.  The patch consists of an abstract class and some interfaces that are used to read and observe ContainerConfig.  Implementors of this class could decide to read their configuration from ContainerConfig or provide values from another source.  This also allows code that needs to use configuration to not have to worry about managing container.js keys.  They can simply ask their provider for values.

I've separated this out from another review as it is generic.  To see an implementation of ValueProvider, you can look at this review: https://reviews.apache.org/r/2362


This addresses bug SHINDIG-1647.
    https://issues.apache.org/jira/browse/SHINDIG-1647


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/config/ValueProvider.java PRE-CREATION 

Diff: https://reviews.apache.org/r/2467/diff


Testing
-------

No specific testing done on the patch, but testing was done in the other review for those classes that implement and use it.


Thanks,

Stanton