You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/05 08:48:57 UTC

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2416: feat: [POC] add since in framework

warren830 commented on code in PR #2416:
URL: https://github.com/apache/incubator-devlake/pull/2416#discussion_r913548286


##########
plugins/github/tasks/issue_extractor.go:
##########
@@ -213,7 +214,7 @@ func ExtractApiIssues(taskCtx core.SubTaskContext) error {
 			}
 			results = append(results, githubIssue)
 
-			return results, nil
+			return results, &githubIssue.GithubUpdatedAt, nil

Review Comment:
   What to do next after returning this `&githubIssue.GithubUpdatedAt`?
    Do we save this to DB or just use a struct to store it in the memory?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org