You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/10/28 10:45:19 UTC

[GitHub] [incubator-ratis] szetszwo opened a new pull request #235: RATIS-1110. Fix DataStreamReply out of order.

szetszwo opened a new pull request #235:
URL: https://github.com/apache/incubator-ratis/pull/235


   See https://issues.apache.org/jira/browse/RATIS-1110


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang commented on pull request #235: RATIS-1110. Fix DataStreamReply out of order.

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #235:
URL: https://github.com/apache/incubator-ratis/pull/235#issuecomment-717916169


   @szetszwo Thanks the patch. After test, I'm sure this patch fix the failure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] szetszwo commented on pull request #235: RATIS-1110. Fix DataStreamReply out of order.

Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #235:
URL: https://github.com/apache/incubator-ratis/pull/235#issuecomment-718121383


   @runzhiwang , thanks for merging this.  I have filed https://issues.apache.org/jira/browse/RATIS-1114 for some code cleanup.  Could you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] szetszwo commented on pull request #235: RATIS-1110. Fix DataStreamReply out of order.

Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #235:
URL: https://github.com/apache/incubator-ratis/pull/235#issuecomment-717851104


   Using thenCombineAsync somehow fixes the failure.  I suspect it is a Java bug.
   
   @runzhiwang , could you test to see if it really can fix the failure?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #235: RATIS-1110. Fix DataStreamReply out of order.

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #235:
URL: https://github.com/apache/incubator-ratis/pull/235#issuecomment-718196438


   > Using thenCombineAsync somehow fixes the failure. I suspect it is a Java bug.
   > 
   > @runzhiwang , could you test to see if it really can fix the failure?
   
   Yes this is wired. My understanding to API with `Async` suffix is those calls are executed separately asynchronously, e.g. `thenSupplyAsync`. But maybe combine is different as combine really means it needs to depends on previous stage. 
   
   Thanks for finding such subtle difference.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang commented on pull request #235: RATIS-1110. Fix DataStreamReply out of order.

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #235:
URL: https://github.com/apache/incubator-ratis/pull/235#issuecomment-717863105


   @szetszwo Sure, let me test it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang merged pull request #235: RATIS-1110. Fix DataStreamReply out of order.

Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #235:
URL: https://github.com/apache/incubator-ratis/pull/235


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org