[jira] [Commented] (WICKET-7030) Add Convenience Methods in BaseWicketTester

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700388#comment-17700388 ] 

ASF GitHub Bot commented on WICKET-7030:
----------------------------------------

renoth commented on code in PR #555:
URL: https://github.com/apache/wicket/pull/555#discussion_r1136240305


##########
wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java:
##########
@@ -1576,6 +1577,48 @@ public Component getComponentFromLastRenderedPage(String path)
 		return getComponentFromLastRenderedPage(path, true);
 	}
 
+	/**
+	 * TODO
+	 *
+	 * @param wicketId
+	 * @return
+	 */
+	public Optional<Component> getFirstComponentFromLastRenderedPageByWicketId(String wicketId) {

Review Comment:
   done





> Add Convenience Methods in BaseWicketTester
> -------------------------------------------
>
>                 Key: WICKET-7030
>                 URL: https://issues.apache.org/jira/browse/WICKET-7030
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>            Reporter: Johannes Renoth
>            Priority: Minor
>
> Since BasewicketTester does not have methods to conveniently search for components by wicket ID only, ignoring the path from last last rendered page, we could add them.
> For example we could add
> {code:java}
> Optional<Component> getFirstComponentByWicketId(String id)
> List<Component> getAllComponentsByWicketId(String id)
> {code}
> to enable the Tester to do the following without the manual use of IVisitor
> {code:java}
> tester.startComponentInPage(myComponent);
> var nestedComponent = tester.getFirstComponentByWicketId("myNestedComponent");
> assertThat(nestedComponent).isPresent(). ...
> // Other Example
> tester.startComponentInPage(myComponentWithListView);
> var result = tester.getAllComponentsByWicketId("repeterNestedItem");
> assertThat(result).hasSize(4)
> .extracting(c -> c.isVisible())
> .containsExactly(true, false, true, true);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)