You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/02/23 06:39:59 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue #782: Can invalid code be removed from the eventmesh-connector-plugin module?
Alonexc opened a new issue #782:
URL: https://github.com/apache/incubator-eventmesh/issues/782
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Question
Some invalid code was found in this module.Such as:
<img width="640" alt="image" src="https://user-images.githubusercontent.com/91315508/155270904-68335b0e-d3ff-4948-86e2-26a301b335f6.png">
<img width="640" alt="image" src="https://user-images.githubusercontent.com/91315508/155270960-05218027-9ead-4074-abb4-4f64a3bc7282.png">
Located in:
1.eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/cloudevent/impl package.
2.eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/utils package.
3.rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/MessagingAccessPointImpl.java This class is commented out.
4.rocketmq/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
5.eventmesh-connector-plugin/eventmesh-connector-standalone/src/main/java/org/apache/eventmesh/connector/standalone/consumer/StandaloneConsumerAdaptor.java
6.eventmesh-connector-plugin/eventmesh-connector-standalone/src/main/java/org/apache/eventmesh/connector/standalone/producer/StandaloneProducerAdaptor.java
Suggestion: Delete invalid code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #782: [Question] Can invalid code be removed from the eventmesh-connector-plugin module?
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #782:
URL: https://github.com/apache/incubator-eventmesh/issues/782#issuecomment-1048530292
> can I have a try?
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] AhahaGe commented on issue #782: [Question] Can invalid code be removed from the eventmesh-connector-plugin module?
Posted by GitBox <gi...@apache.org>.
AhahaGe commented on issue #782:
URL: https://github.com/apache/incubator-eventmesh/issues/782#issuecomment-1048528198
can I have a try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] AhahaGe commented on issue #782: [Question] Can invalid code be removed from the eventmesh-connector-plugin module?
Posted by GitBox <gi...@apache.org>.
AhahaGe commented on issue #782:
URL: https://github.com/apache/incubator-eventmesh/issues/782#issuecomment-1048531226
please assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #782: [Enhancement] invalid code can be removed from the eventmesh-connector-plugin module
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #782:
URL: https://github.com/apache/incubator-eventmesh/issues/782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org