You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2024/01/18 05:49:13 UTC
[PR] [WW-5369] Re-define minimal library set [struts]
lukaszlenart opened a new pull request, #847:
URL: https://github.com/apache/struts/pull/847
This PR adds missing `caffeine-x.x.x.jar` & `javassist-x.x.x.jar`
[WW-5369](https://issues.apache.org/jira/browse/WW-5369)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WW-5369] Re-define minimal library set [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #847:
URL: https://github.com/apache/struts/pull/847#issuecomment-1898075270
The min-lib is used by ppl who do not use Maven, so caffeine is required to start the app in such a case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WW-5369] Re-define minimal library set [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on PR #847:
URL: https://github.com/apache/struts/pull/847#issuecomment-1898098815
Yeah makes sense - best to distribute it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WW-5369] Re-define minimal library set [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #847:
URL: https://github.com/apache/struts/pull/847#issuecomment-1898096427
We can either use `basic` and then make Caffeine `optional` in `pom.xml` or distribute it with the minimal set. Most of the uses rarely change the default settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WW-5369] Re-define minimal library set [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on PR #847:
URL: https://github.com/apache/struts/pull/847#issuecomment-1898080596
If their `struts.properties` has
```
struts.ognl.expressionCacheType=basic
struts.ognl.beanInfoCacheType=basic
```
then Caffeine won't be required - but given the default configuration requires it, probably best to include it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WW-5369] Re-define minimal library set [struts]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #847:
URL: https://github.com/apache/struts/pull/847#issuecomment-1897848698
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=847) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=847&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=847&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=847)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WW-5369] Re-define minimal library set [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #847:
URL: https://github.com/apache/struts/pull/847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org