You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/23 23:01:19 UTC
[GitHub] [maven-doxia] hboutemy opened a new pull request, #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
hboutemy opened a new pull request, #133:
URL: https://github.com/apache/maven-doxia/pull/133
https://issues.apache.org/jira/browse/DOXIA-684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia] hboutemy closed pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
Posted by GitBox <gi...@apache.org>.
hboutemy closed pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
URL: https://github.com/apache/maven-doxia/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia] michael-o commented on a diff in pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #133:
URL: https://github.com/apache/maven-doxia/pull/133#discussion_r1058501071
##########
doxia-modules/doxia-module-markdown/pom.xml:
##########
@@ -51,19 +51,57 @@ under the License.
</contributor>
</contributors>
+ <properties>
+ <flexmark.version>0.42.14</flexmark.version>
Review Comment:
master is at https://github.com/apache/maven-doxia/blob/master/doxia-modules/doxia-module-markdown/pom.xml#L67 `0.62.2`, 1.11.x requires a different version though
##########
doxia-modules/doxia-module-markdown/pom.xml:
##########
@@ -51,19 +51,57 @@ under the License.
</contributor>
</contributors>
+ <properties>
+ <flexmark.version>0.42.14</flexmark.version>
Review Comment:
I think we should use the camelCase approach for version properties everywhere now: `flexmarkVersion`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia] hboutemy commented on pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #133:
URL: https://github.com/apache/maven-doxia/pull/133#issuecomment-1364382230
just used https://github.com/vsch/flexmark-java/blob/master/flexmark-all/pom.xml to know the existing artifactIds, then added the missing ones for the used classes: nothing hard, just some not funny time to find the 8 ones :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia] michael-o commented on pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #133:
URL: https://github.com/apache/maven-doxia/pull/133#issuecomment-1364376198
Nice, how did you determine that list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia] michael-o commented on a diff in pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #133:
URL: https://github.com/apache/maven-doxia/pull/133#discussion_r1058504876
##########
doxia-modules/doxia-module-markdown/pom.xml:
##########
@@ -51,19 +51,57 @@ under the License.
</contributor>
</contributors>
+ <properties>
+ <flexmark.version>0.42.14</flexmark.version>
Review Comment:
If for 1.x then then PR is wrong. IT targets master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia] hboutemy commented on pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #133:
URL: https://github.com/apache/maven-doxia/pull/133#issuecomment-1366828469
merged in 539428bd17e649c506e4a7a549b8f8b5d1cc3c18 for Doxia 1.x and e6848f9e4b2fdeaa3378183d8b557d55fb476ad6 for Doxia 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia] michael-o commented on pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #133:
URL: https://github.com/apache/maven-doxia/pull/133#issuecomment-1366818558
Yet another issue:
```
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ doxia-module-markdown ---
[WARNING] Used undeclared dependencies found:
[WARNING] com.vladsch.flexmark:flexmark-util:jar:0.42.14:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #133: [DOXIA-684] avoid flexmark-all: declare used extensions only
Posted by GitBox <gi...@apache.org>.
hboutemy commented on code in PR #133:
URL: https://github.com/apache/maven-doxia/pull/133#discussion_r1058502995
##########
doxia-modules/doxia-module-markdown/pom.xml:
##########
@@ -51,19 +51,57 @@ under the License.
</contributor>
</contributors>
+ <properties>
+ <flexmark.version>0.42.14</flexmark.version>
Review Comment:
done the camelCase, you're right, it's what we do for parent POMs
on version, yes, the current PR is for Doxia 1.x, Doxia 2.x will get another version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org