You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Neil Griffin (JIRA)" <de...@myfaces.apache.org> on 2012/06/29 18:54:43 UTC
[jira] [Created] (TRINIDAD-2284) Trinidad CoreForm does not render
standard javax.faces.encodedURL hidden field
Neil Griffin created TRINIDAD-2284:
--------------------------------------
Summary: Trinidad CoreForm does not render standard javax.faces.encodedURL hidden field
Key: TRINIDAD-2284
URL: https://issues.apache.org/jira/browse/TRINIDAD-2284
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 2.0.1-core
Reporter: Neil Griffin
Trinidad PPR Ajax does not work in JSF 2 portlet bridges (like Liferay Faces Bridge) because the renderer for tr:form does not render the standard hidden field:
<input type="hidden" name="javax.faces.encodedURL" value="..." />
http://docs.oracle.com/javaee/6/javaserverfaces/2.1/docs/renderkitdocs/HTML_BASIC/javax.faces.Formjavax.faces.Form.html
Since the field is not rendered, jsf.js uses the "action" attribute of the form, which invokes the ACTION_PHASE of the portlet lifecycle. If the hidden field is rendered properly, then the value of the hidden field is a portlet ResourceURL which invokes the RESOURCE_PHASE of the portlet lifecycle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2284) Trinidad CoreForm does not render
standard javax.faces.encodedURL hidden field
Posted by "Thomas Möller (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Möller updated TRINIDAD-2284:
------------------------------------
Status: Patch Available (was: Open)
> Trinidad CoreForm does not render standard javax.faces.encodedURL hidden field
> ------------------------------------------------------------------------------
>
> Key: TRINIDAD-2284
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2284
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.1-core
> Reporter: Neil Griffin
>
> Trinidad PPR Ajax does not work in JSF 2 portlet bridges (like Liferay Faces Bridge) because the renderer for tr:form does not render the standard hidden field:
> <input type="hidden" name="javax.faces.encodedURL" value="..." />
> http://docs.oracle.com/javaee/6/javaserverfaces/2.1/docs/renderkitdocs/HTML_BASIC/javax.faces.Formjavax.faces.Form.html
> Since the field is not rendered, jsf.js uses the "action" attribute of the form, which invokes the ACTION_PHASE of the portlet lifecycle. If the hidden field is rendered properly, then the value of the hidden field is a portlet ResourceURL which invokes the RESOURCE_PHASE of the portlet lifecycle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TRINIDAD-2284) Trinidad CoreForm does not
render standard javax.faces.encodedURL hidden field
Posted by "Neil Griffin (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440277#comment-13440277 ]
Neil Griffin edited comment on TRINIDAD-2284 at 8/24/12 12:30 AM:
------------------------------------------------------------------
Thanks for providing a patch. It would be nice to see this fixed soon.
FWIW, this is the temporary workaround that I came up with: [ViewDeclarationLanguageJspTCKImpl.java|https://github.com/liferay/liferay-faces/blob/master/test/bridge-tck-compat/src/main/java/com/liferay/faces/bridge/tck/application/view/ViewDeclarationLanguageJspTCKImpl.java] and [ViewDeclarationLanguageFactoryTCKImpl.java|https://github.com/liferay/liferay-faces/blob/master/test/bridge-tck-compat/src/main/java/com/liferay/faces/bridge/tck/application/view/ViewDeclarationLanguageFactoryTCKImpl.java]
Also, this requires registration in faces-config.xml:
{code}
<factory>
<view-declaration-language-factory>com.liferay.faces.bridge.tck.application.view.ViewDeclarationLanguageFactoryTCKImpl</view-declaration-language-factory>
</factory>
{code}
BTW, you can ignore the "JSP" part of the class names. The workaround was implemented for making Liferay Faces Bridge compatible with the JSR 329 TCK which uses JSP (not Facelets), but it should work for Facelets too.
was (Author: ngriffin7a):
Thanks for providing a patch. It would be nice to see this fixed soon.
FWIW, this is the temporary workaround that I came up with: [ViewDeclarationLanguageJspTCKImpl.java|https://github.com/liferay/liferay-faces/blob/master/test/bridge-tck-compat/src/main/java/com/liferay/faces/bridge/tck/application/view/ViewDeclarationLanguageJspTCKImpl.java] and [ViewDeclarationLanguageFactoryTCKImpl.java|https://github.com/liferay/liferay-faces/blob/master/test/bridge-tck-compat/src/main/java/com/liferay/faces/bridge/tck/application/view/ViewDeclarationLanguageFactoryTCKImpl.java]
Also, this requires registration in faces-config.xml:
{code}
<factory>
<view-declaration-language-factory>com.liferay.faces.bridge.tck.application.view.ViewDeclarationLanguageFactoryTCKImpl</view-declaration-language-factory>
</factory>
{code}
> Trinidad CoreForm does not render standard javax.faces.encodedURL hidden field
> ------------------------------------------------------------------------------
>
> Key: TRINIDAD-2284
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2284
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.1-core
> Reporter: Neil Griffin
> Attachments: patch.zip
>
>
> Trinidad PPR Ajax does not work in JSF 2 portlet bridges (like Liferay Faces Bridge) because the renderer for tr:form does not render the standard hidden field:
> <input type="hidden" name="javax.faces.encodedURL" value="..." />
> http://docs.oracle.com/javaee/6/javaserverfaces/2.1/docs/renderkitdocs/HTML_BASIC/javax.faces.Formjavax.faces.Form.html
> Since the field is not rendered, jsf.js uses the "action" attribute of the form, which invokes the ACTION_PHASE of the portlet lifecycle. If the hidden field is rendered properly, then the value of the hidden field is a portlet ResourceURL which invokes the RESOURCE_PHASE of the portlet lifecycle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2284) Trinidad CoreForm does not
render standard javax.faces.encodedURL hidden field
Posted by "Neil Griffin (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440277#comment-13440277 ]
Neil Griffin commented on TRINIDAD-2284:
----------------------------------------
Thanks for providing a patch. It would be nice to see this fixed soon.
FWIW, this is the temporary workaround that I came up with: [ViewDeclarationLanguageJspTCKImpl.java|https://github.com/liferay/liferay-faces/blob/master/test/bridge-tck-compat/src/main/java/com/liferay/faces/bridge/tck/application/view/ViewDeclarationLanguageJspTCKImpl.java] and [ViewDeclarationLanguageFactoryTCKImpl.java|https://github.com/liferay/liferay-faces/blob/master/test/bridge-tck-compat/src/main/java/com/liferay/faces/bridge/tck/application/view/ViewDeclarationLanguageFactoryTCKImpl.java]
Also, this requires registration in faces-config.xml:
{code}
<factory>
<view-declaration-language-factory>com.liferay.faces.bridge.tck.application.view.ViewDeclarationLanguageFactoryTCKImpl</view-declaration-language-factory>
</factory>
{code}
> Trinidad CoreForm does not render standard javax.faces.encodedURL hidden field
> ------------------------------------------------------------------------------
>
> Key: TRINIDAD-2284
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2284
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.1-core
> Reporter: Neil Griffin
> Attachments: patch.zip
>
>
> Trinidad PPR Ajax does not work in JSF 2 portlet bridges (like Liferay Faces Bridge) because the renderer for tr:form does not render the standard hidden field:
> <input type="hidden" name="javax.faces.encodedURL" value="..." />
> http://docs.oracle.com/javaee/6/javaserverfaces/2.1/docs/renderkitdocs/HTML_BASIC/javax.faces.Formjavax.faces.Form.html
> Since the field is not rendered, jsf.js uses the "action" attribute of the form, which invokes the ACTION_PHASE of the portlet lifecycle. If the hidden field is rendered properly, then the value of the hidden field is a portlet ResourceURL which invokes the RESOURCE_PHASE of the portlet lifecycle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TRINIDAD-2284) Trinidad CoreForm does not
render standard javax.faces.encodedURL hidden field
Posted by "Thomas Möller (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440231#comment-13440231 ]
Thomas Möller edited comment on TRINIDAD-2284 at 8/23/12 11:14 PM:
-------------------------------------------------------------------
I provided a patch that implements the rendering of javax.faces.encodedURL. In my scenario (liferay 6.1.1, mojarra 2.1.3-b02, bridge 3.1.0-rc2) PPRs work now.
Attention: in my test I had to 1) include the mojarra.js myself via <h:outputScript name="jsf.js" library="javax.faces" target="head" /> and 2) define an id for the PPR-triggering component.
was (Author: thomoell):
I provided a patch that implements the behaviour that I found here: http://javaserverfaces.java.net/nonav/docs/2.0/pdldocs/facelets/h/form.html. In my scenario (liferay 6.1.1, mojarra 2.1.3-b02, bridge 3.1.0-rc2) PPRs work now.
Attention: in my test I had to 1) include the mojarra.js myself via <h:outputScript name="jsf.js" library="javax.faces" target="head" /> and 2) define an id for the PPR-triggering component.
> Trinidad CoreForm does not render standard javax.faces.encodedURL hidden field
> ------------------------------------------------------------------------------
>
> Key: TRINIDAD-2284
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2284
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.1-core
> Reporter: Neil Griffin
> Attachments: patch.zip
>
>
> Trinidad PPR Ajax does not work in JSF 2 portlet bridges (like Liferay Faces Bridge) because the renderer for tr:form does not render the standard hidden field:
> <input type="hidden" name="javax.faces.encodedURL" value="..." />
> http://docs.oracle.com/javaee/6/javaserverfaces/2.1/docs/renderkitdocs/HTML_BASIC/javax.faces.Formjavax.faces.Form.html
> Since the field is not rendered, jsf.js uses the "action" attribute of the form, which invokes the ACTION_PHASE of the portlet lifecycle. If the hidden field is rendered properly, then the value of the hidden field is a portlet ResourceURL which invokes the RESOURCE_PHASE of the portlet lifecycle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2284) Trinidad CoreForm does not
render standard javax.faces.encodedURL hidden field
Posted by "Thomas Möller (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440231#comment-13440231 ]
Thomas Möller commented on TRINIDAD-2284:
-----------------------------------------
I provided a patch that implements the behaviour that I found here: http://javaserverfaces.java.net/nonav/docs/2.0/pdldocs/facelets/h/form.html. In my scenario (liferay 6.1.1, mojarra 2.1.3-b02, bridge 3.1.0-rc2) PPRs work now.
Attention: in my test I had to 1) include the mojarra.js myself via <h:outputScript name="jsf.js" library="javax.faces" target="head" /> and 2) define an id for the PPR-triggering component.
> Trinidad CoreForm does not render standard javax.faces.encodedURL hidden field
> ------------------------------------------------------------------------------
>
> Key: TRINIDAD-2284
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2284
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.1-core
> Reporter: Neil Griffin
> Attachments: patch.zip
>
>
> Trinidad PPR Ajax does not work in JSF 2 portlet bridges (like Liferay Faces Bridge) because the renderer for tr:form does not render the standard hidden field:
> <input type="hidden" name="javax.faces.encodedURL" value="..." />
> http://docs.oracle.com/javaee/6/javaserverfaces/2.1/docs/renderkitdocs/HTML_BASIC/javax.faces.Formjavax.faces.Form.html
> Since the field is not rendered, jsf.js uses the "action" attribute of the form, which invokes the ACTION_PHASE of the portlet lifecycle. If the hidden field is rendered properly, then the value of the hidden field is a portlet ResourceURL which invokes the RESOURCE_PHASE of the portlet lifecycle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2284) Trinidad CoreForm does not
render standard javax.faces.encodedURL hidden field
Posted by "Thomas Möller (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440239#comment-13440239 ]
Thomas Möller commented on TRINIDAD-2284:
-----------------------------------------
One thing to mention: the tests fail but I don't know how to fix this.
> Trinidad CoreForm does not render standard javax.faces.encodedURL hidden field
> ------------------------------------------------------------------------------
>
> Key: TRINIDAD-2284
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2284
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 2.0.1-core
> Reporter: Neil Griffin
> Attachments: patch.zip
>
>
> Trinidad PPR Ajax does not work in JSF 2 portlet bridges (like Liferay Faces Bridge) because the renderer for tr:form does not render the standard hidden field:
> <input type="hidden" name="javax.faces.encodedURL" value="..." />
> http://docs.oracle.com/javaee/6/javaserverfaces/2.1/docs/renderkitdocs/HTML_BASIC/javax.faces.Formjavax.faces.Form.html
> Since the field is not rendered, jsf.js uses the "action" attribute of the form, which invokes the ACTION_PHASE of the portlet lifecycle. If the hidden field is rendered properly, then the value of the hidden field is a portlet ResourceURL which invokes the RESOURCE_PHASE of the portlet lifecycle.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira